FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.1

Threshold is medium

Effort is min

Summary

ClassesBugsErrorsMissing Classes
564100

org.apache.maven.plugin.announcement.AnnouncementMailMojo

BugCategoryDetailsLinePriority
Found reliance on default encoding in org.apache.maven.plugin.announcement.AnnouncementMailMojo.readAnnouncement(File): new java.io.FileReader(File)I18NDM_DEFAULT_ENCODING325High

org.apache.maven.plugin.announcement.AnnouncementMojo

BugCategoryDetailsLinePriority
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.announcement.AnnouncementMojo.processTemplate(Context, File, String, String)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE602Medium

org.apache.maven.plugin.announcement.mailsender.ProjectJavamailMailSender

BugCategoryDetailsLinePriority
Unwritten field: org.apache.maven.plugin.announcement.mailsender.ProjectJavamailMailSender.userPropertiesCORRECTNESSUWF_UNWRITTEN_FIELD107Medium

org.apache.maven.plugin.changes.AbstractChangesReport

BugCategoryDetailsLinePriority
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.changes.AbstractChangesReport.execute()BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE182Medium

org.apache.maven.plugin.changes.ChangesCheckMojo

BugCategoryDetailsLinePriority
Unread field: org.apache.maven.plugin.changes.ChangesCheckMojo.releaseUtilsPERFORMANCEURF_UNREAD_FIELD73Medium

org.apache.maven.plugin.changes.ChangesMojo

BugCategoryDetailsLinePriority
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.changes.ChangesMojo.getChangesFromFile(File, MavenProject, Properties)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE365Medium

org.apache.maven.plugin.changes.ChangesReportGenerator

BugCategoryDetailsLinePriority
org.apache.maven.plugin.changes.ChangesReportGenerator.constructDueTo(Sink, Action, ResourceBundle, List) makes inefficient use of keySet iterator instead of entrySet iteratorPERFORMANCEWMI_WRONG_MAP_ITERATOR333Medium

org.apache.maven.plugin.changes.ChangesXML

BugCategoryDetailsLinePriority
new org.apache.maven.plugin.changes.ChangesXML(File, Log) may fail to clean up java.io.InputStreamEXPERIMENTALOBL_UNSATISFIED_OBLIGATION65Medium
Redundant nullcheck of org.apache.maven.plugin.changes.ChangesXML.changesDocument, which is known to be non-null in new org.apache.maven.plugin.changes.ChangesXML(File, Log)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE67Medium

org.apache.maven.plugin.changes.HelpMojo

BugCategoryDetailsLinePriority
Unwritten field: org.apache.maven.plugin.changes.HelpMojo.goalCORRECTNESSUWF_UNWRITTEN_FIELD129Medium

org.apache.maven.plugin.github.GitHubMojo

BugCategoryDetailsLinePriority
org.apache.maven.plugin.github.GitHubMojo.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR58Medium

org.apache.maven.plugin.issues.Issue

BugCategoryDetailsLinePriority
org.apache.maven.plugin.issues.Issue.getCreated() may expose internal representation by returning Issue.createdMALICIOUS_CODEEI_EXPOSE_REP113Medium
org.apache.maven.plugin.issues.Issue.getUpdated() may expose internal representation by returning Issue.updatedMALICIOUS_CODEEI_EXPOSE_REP237Medium
org.apache.maven.plugin.issues.Issue.setCreated(Date) may expose internal representation by storing an externally mutable object into Issue.createdMALICIOUS_CODEEI_EXPOSE_REP2118Medium
org.apache.maven.plugin.issues.Issue.setUpdated(Date) may expose internal representation by storing an externally mutable object into Issue.updatedMALICIOUS_CODEEI_EXPOSE_REP2242Medium

org.apache.maven.plugin.issues.IssuesReportGenerator

BugCategoryDetailsLinePriority
new org.apache.maven.plugin.issues.IssuesReportGenerator(int[]) may expose internal representation by storing an externally mutable object into IssuesReportGenerator.columnsMALICIOUS_CODEEI_EXPOSE_REP255Medium

org.apache.maven.plugin.jira.AbstractJiraDownloader

BugCategoryDetailsLinePriority
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.jira.AbstractJiraDownloader.download(HttpClient, String)BAD_PRACTICERV_RETURN_VALUE_IGNORED_BAD_PRACTICE554Medium

org.apache.maven.plugin.jira.JiraHelper

BugCategoryDetailsLinePriority
org.apache.maven.plugin.jira.JiraHelper.validateNonProxyHosts(ProxyInfo, String) invokes inefficient new String() constructorPERFORMANCEDM_STRING_VOID_CTOR163Medium

org.apache.maven.plugin.jira.JiraMojo

BugCategoryDetailsLinePriority
org.apache.maven.plugin.jira.JiraMojo.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR59Medium

org.apache.maven.plugin.trac.TracDownloader

BugCategoryDetailsLinePriority
org.apache.maven.plugin.trac.TracDownloader.getIssueList() invokes inefficient new String(String) constructorPERFORMANCEDM_STRING_CTOR121Medium

org.apache.maven.plugin.trac.TracMojo

BugCategoryDetailsLinePriority
org.apache.maven.plugin.trac.TracMojo.<static initializer>() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) insteadPERFORMANCEDM_NUMBER_CTOR62Medium

org.apache.maven.plugins.changes.model.Action

BugCategoryDetailsLinePriority
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.addDueTo(DueTo), since all org.apache.maven.plugins.changes.model.DueTo are instances of org.apache.maven.plugins.changes.model.DueToSTYLEBC_VACUOUS_INSTANCEOF142Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.addFixedIssue(FixedIssue), since all org.apache.maven.plugins.changes.model.FixedIssue are instances of org.apache.maven.plugins.changes.model.FixedIssueSTYLEBC_VACUOUS_INSTANCEOF156Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.removeDueTo(DueTo), since all org.apache.maven.plugins.changes.model.DueTo are instances of org.apache.maven.plugins.changes.model.DueToSTYLEBC_VACUOUS_INSTANCEOF309Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Action.removeFixedIssue(FixedIssue), since all org.apache.maven.plugins.changes.model.FixedIssue are instances of org.apache.maven.plugins.changes.model.FixedIssueSTYLEBC_VACUOUS_INSTANCEOF323Medium

org.apache.maven.plugins.changes.model.Body

BugCategoryDetailsLinePriority
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Body.addRelease(Release), since all org.apache.maven.plugins.changes.model.Release are instances of org.apache.maven.plugins.changes.model.ReleaseSTYLEBC_VACUOUS_INSTANCEOF40Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Body.removeRelease(Release), since all org.apache.maven.plugins.changes.model.Release are instances of org.apache.maven.plugins.changes.model.ReleaseSTYLEBC_VACUOUS_INSTANCEOF69Medium

org.apache.maven.plugins.changes.model.Component

BugCategoryDetailsLinePriority
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Component.addAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.ActionSTYLEBC_VACUOUS_INSTANCEOF56Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Component.removeAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.ActionSTYLEBC_VACUOUS_INSTANCEOF105Medium

org.apache.maven.plugins.changes.model.Release

BugCategoryDetailsLinePriority
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Release.addAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.ActionSTYLEBC_VACUOUS_INSTANCEOF65Medium
instanceof will always return true for all nonnull values in org.apache.maven.plugins.changes.model.Release.removeAction(Action), since all org.apache.maven.plugins.changes.model.Action are instances of org.apache.maven.plugins.changes.model.ActionSTYLEBC_VACUOUS_INSTANCEOF126Medium

org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader

BugCategoryDetailsLinePriority
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseBody(String, XmlPullParser, boolean)STYLEDLS_DEAD_LOCAL_STORE577High
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseDueTo(String, XmlPullParser, boolean)STYLEDLS_DEAD_LOCAL_STORE737High
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseFixedIssue(String, XmlPullParser, boolean)STYLEDLS_DEAD_LOCAL_STORE771High
Dead store to parsed in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseRelease(String, XmlPullParser, boolean)STYLEDLS_DEAD_LOCAL_STORE854High
Redundant nullcheck of dueTos, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseAction(String, XmlPullParser, boolean)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE498Medium
Redundant nullcheck of fixedIssues, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseAction(String, XmlPullParser, boolean)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE488Medium
Redundant nullcheck of releases, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseBody(String, XmlPullParser, boolean)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE583Medium
Redundant nullcheck of actions, which is known to be non-null in org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.parseRelease(String, XmlPullParser, boolean)STYLERCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE860Medium
Private method org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD109Medium
Private method org.apache.maven.plugins.changes.model.io.xpp3.ChangesXpp3Reader.getDateValue(String, String, XmlPullParser) is never calledPERFORMANCEUPM_UNCALLED_PRIVATE_METHOD197Medium