The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugins.shade.DefaultShader.shade(Set, File, List, List, List) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 79 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.maven.plugins.shade.DefaultShader$RelocatorRemapper be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 345-425 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method new org.apache.maven.plugins.shade.filter.MinijarFilter(MavenProject, Log) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 63 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugins.shade.mojo.ArchiveFilter.artifact | CORRECTNESS | UWF_UNWRITTEN_FIELD | 37 | Medium |
| Unwritten field: org.apache.maven.plugins.shade.mojo.ArchiveFilter.excludes | CORRECTNESS | UWF_UNWRITTEN_FIELD | 47 | Medium |
| Unwritten field: org.apache.maven.plugins.shade.mojo.ArchiveFilter.includes | CORRECTNESS | UWF_UNWRITTEN_FIELD | 42 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugins.shade.mojo.ArtifactSet.excludes | CORRECTNESS | UWF_UNWRITTEN_FIELD | 38 | Medium |
| Unwritten field: org.apache.maven.plugins.shade.mojo.ArtifactSet.includes | CORRECTNESS | UWF_UNWRITTEN_FIELD | 33 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugins.shade.mojo.HelpMojo.goal | CORRECTNESS | UWF_UNWRITTEN_FIELD | 76 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugins.shade.mojo.PackageRelocation.excludes | CORRECTNESS | UWF_UNWRITTEN_FIELD | 55 | Medium |
| Unwritten field: org.apache.maven.plugins.shade.mojo.PackageRelocation.includes | CORRECTNESS | UWF_UNWRITTEN_FIELD | 50 | Medium |
| Unwritten field: org.apache.maven.plugins.shade.mojo.PackageRelocation.pattern | CORRECTNESS | UWF_UNWRITTEN_FIELD | 40 | Medium |
| Unwritten field: org.apache.maven.plugins.shade.mojo.PackageRelocation.shadedPattern | CORRECTNESS | UWF_UNWRITTEN_FIELD | 45 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugins.shade.mojo.ShadeMojo.replaceFile(File, File) forces garbage collection; extremely dubious except in benchmarking code | PERFORMANCE | DM_GC | 515 | High |
| Method org.apache.maven.plugins.shade.mojo.ShadeMojo.replaceFile(File, File) may fail to clean up java.io.OutputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 553 | Medium |
| Exception is caught when Exception is not thrown in org.apache.maven.plugins.shade.mojo.ShadeMojo.execute() | STYLE | REC_CATCH_EXCEPTION | 501 | Medium |
| org.apache.maven.plugins.shade.mojo.ShadeMojo.createDependencyReducedPom(Set) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 828 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.maven.plugins.shade.pom.MavenJDOMWriter.insertAtPreferredLocation(Element, Element, MavenJDOMWriter$Counter) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 298 | Medium |
| Method org.apache.maven.plugins.shade.pom.MavenJDOMWriter.findAndReplaceProperties(MavenJDOMWriter$Counter, Element, String, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 143 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.apache.maven.plugins.shade.pom.MavenJDOMWriter$Counter be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 2197-2239 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer.entries | PERFORMANCE | URF_UNREAD_FIELD | 40 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer.encoding | CORRECTNESS | UWF_UNWRITTEN_FIELD | 118 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugins.shade.resource.AppendingTransformer.resource | CORRECTNESS | UWF_UNWRITTEN_FIELD | 44 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugins.shade.resource.DontIncludeResourceTransformer.resource | CORRECTNESS | UWF_UNWRITTEN_FIELD | 39 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugins.shade.resource.IncludeResourceTransformer.file | CORRECTNESS | UWF_UNWRITTEN_FIELD | 55 | Medium |
| Unwritten field: org.apache.maven.plugins.shade.resource.IncludeResourceTransformer.resource | CORRECTNESS | UWF_UNWRITTEN_FIELD | 61 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugins.shade.resource.ManifestResourceTransformer.mainClass | CORRECTNESS | UWF_UNWRITTEN_FIELD | 95 | Medium |
| Unwritten field: org.apache.maven.plugins.shade.resource.ManifestResourceTransformer.manifestEntries | CORRECTNESS | UWF_UNWRITTEN_FIELD | 100 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugins.shade.resource.XmlAppendingTransformer.resource | CORRECTNESS | UWF_UNWRITTEN_FIELD | 58 | Medium |