The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
| Tag | Total number of occurrences |
|---|---|
| @todo | 13 |
| TODO | 53 |
Each tag is detailed below:
Number of occurrences found in the code: 13
| org.apache.maven.project.DefaultMavenProjectBuilder | Line |
|---|---|
| move to metadatasource itself? | 347 |
| can this take in a model instead of a project and still be successful? | 955 |
| In fact, does project REALLY need a MavenProject as a parent? Couldn't it have just a wrapper around a model that supported parents which were also the wrapper so that inheritence was assembled. We don't really need the resolved source roots, etc for the parent - that occurs for the parent when it is constructed independently and projects are not cached or reused | 956 |
| We need to find an effective way to unit test parts of this method! | 1128 |
| Refactor this into smaller methods with discrete purposes. | 1129 |
| org.apache.maven.project.MavenProject | Line |
| I would like to get rid of this. jvz. | 359 |
| the lazy initialisation of this makes me uneasy. | 1570 |
| org.apache.maven.project.ProjectClasspathTest | Line |
| relocate to maven-artifact in entirety | 28 |
| org.apache.maven.project.artifact.ActiveProjectArtifact | Line |
| I think this exposes a design flaw in that the immutable and mutable parts of an artifact are in one class and should be split. ie scope, file, etc depend on the context of use, whereas everything else is immutable. | 42 |
| org.apache.maven.project.artifact.MavenMetadataSource | Line |
| desperately needs refactoring. It's just here because it's implementation is maven-project specific | 391 |
| org.apache.maven.project.inheritance.DefaultModelInheritanceAssembler | Line |
| generate this with modello to keep it in sync with changes in the model. | 48 |
| org.apache.maven.project.interpolation.RegexBasedModelInterpolator | Line |
| Consolidate this logic with the PluginParameterExpressionEvaluator, minus deprecations/bans. | 45 |
| org.apache.maven.project.overlay.BuildOverlay | Line |
| why delegate? this is asking for trouble when there are additions. | 33 |
Number of occurrences found in the code: 53
| org.apache.maven.project.DefaultMavenProjectBuilder | Line |
|---|---|
| remove | 142 |
| make it a component | 163 |
| mkleint - use the (Container, Properties) constructor to make system properties embeddable | 268 |
| such a call in MavenMetadataSource too - packaging not really the intention of type | 368 |
| this is gross. Would like to give it the whole model, but maven-artifact shouldn't depend on that Can a maven-core implementation of the Artifact interface store it, and be used in the exceptions? | 576 |
| configurable actions dependant on status | 663 |
| re-enable [MNG-798/865] | 668 |
| not correct in some instances | 713 |
| the aRWR can get out of sync with project.model.repositories. We should do all the processing of profiles, etc on the models then recreate the aggregated sets at the end from the project repositories (they must still be created along the way so that parent poms can be discovered, however) Use a TreeSet to ensure ordering is retained | 769 |
| maybe not strictly correct, while we should enfore that packaging has a type handler of the same id, we don't | 1048 |
| these aren't taking active project artifacts into consideration in the reactor | 1116 |
| mkleint - use the (Container, Properties constructor to make system properties embeddable | 1156 |
| share with createPluginArtifacts? | 1667 |
| share with createPluginArtifacts? | 1713 |
| org.apache.maven.project.MavenProject | Line |
| let the scope handler deal with this | 505 |
| classpath check doesn't belong here - that's the other method | 524 |
| let the scope handler deal with this | 527 |
| let the scope handler deal with this | 553 |
| let the scope handler deal with this NOTE: [jc] scope == 'test' is the widest possible scope, so we don't really need to perform this check... if ( Artifact.SCOPE_TEST.equals( a.getScope() ) || Artifact.SCOPE_COMPILE.equals( a.getScope() ) || Artifact.SCOPE_RUNTIME.equals( a.getScope() ) ) { } | 587 |
| classpath check doesn't belong here - that's the other method | 613 |
| let the scope handler deal with this NOTE: [jc] scope == 'test' is the widest possible scope, so we don't really need to perform this check... if ( Artifact.SCOPE_TEST.equals( a.getScope() ) || Artifact.SCOPE_COMPILE.equals( a.getScope() ) || Artifact.SCOPE_RUNTIME.equals( a.getScope() ) ) { list.add( a ); } | 616 |
| let the scope handler deal with this NOTE: [jc] scope == 'test' is the widest possible scope, so we don't really need to perform this check... if ( Artifact.SCOPE_TEST.equals( a.getScope() ) || Artifact.SCOPE_COMPILE.equals( a.getScope() ) || Artifact.SCOPE_RUNTIME.equals( a.getScope() ) ) { } | 646 |
| let the scope handler deal with this | 681 |
| classpath check doesn't belong here - that's the other method | 704 |
| let the scope handler deal with this | 707 |
| let the scope handler deal with this | 732 |
| let the scope handler deal with this | 763 |
| classpath check doesn't belong here - that's the other method | 781 |
| let the scope handler deal with this | 784 |
| let the scope handler deal with this | 809 |
| this should not be allowed to be null. | 880 |
| if not matching, we should get the correct artifact from that project (attached) | 1672 |
| ... | 1683 |
| if I use the original, I get an exception below: | 1694 |
| org.apache.maven.project.ModelUtils | Line |
| it's pretty much a copy of {@link #mergePluginLists(PluginContainer, PluginContainer, boolean)} | 270 |
| would be nice for the modello:java code to generate this as a copy constructor | 606 |
| Implement deep-copy of configuration. | 724 |
| Deep-copy config. | 751 |
| Deep-copy this! | 1026 |
| Deep-copy configs. | 1052 |
| org.apache.maven.project.ProjectSorter | Line |
| !![jc; 28-jul-2005] check this; if we're using '-r' and there are aggregator tasks, this will result in weirdness. | 198 |
| org.apache.maven.project.ProjectUtils | Line |
| make this a map inside the factory instead, so no lookup needed | 77 |
| make this a map inside the factory instead, so no lookup needed | 109 |
| org.apache.maven.project.artifact.MavenMetadataSource | Line |
| can we just modify the original? | 142 |
| this could come straight from the project, negating the need to set it in the project itself? | 296 |
| we could possibly use p.getDependencyArtifacts instead of this call, but they haven't been filtered or used the inherited scope (should that be passed to the buildFromRepository method above?) | 314 |
| org.apache.maven.project.inheritance.DefaultModelInheritanceAssembler | Line |
| This should eventually be migrated to DefaultPathTranslator. | 467 |
| Move this to plexus-utils' PathTool. | 508 |
| org.apache.maven.project.inheritance.DefaultModelInheritanceAssemblerTest | Line |
| this is probably what we should be appending... child.setUrl( "/child.dir" ); | 65 |
| test inheritence/super pom? List childExcludesTest = child.getBuild().getUnitTest().getExcludes(); | 346 |
| a lot easier if modello generated equals() :) | 496 |
| a lot easier if modello generated equals() :) | 512 |
| a lot easier if modello generated equals() :) | 527 |
