FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
159 44 0 0

org.apache.maven.artifact.manager.DefaultWagonManager

Bug Category Details Line Priority
The class name org.apache.maven.artifact.manager.DefaultWagonManager shadows the simple name of the superclass org.apache.maven.repository.legacy.DefaultWagonManager BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 46-179 High

org.apache.maven.artifact.manager.WagonConfigurationException

Bug Category Details Line Priority
The class name org.apache.maven.artifact.manager.WagonConfigurationException shadows the simple name of the superclass org.apache.maven.repository.legacy.WagonConfigurationException BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 31-37 High

org.apache.maven.artifact.manager.WagonManager

Bug Category Details Line Priority
The class name org.apache.maven.artifact.manager.WagonManager shadows the simple name of implemented interface org.apache.maven.repository.legacy.WagonManager BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_INTERFACE Not available Medium

org.apache.maven.artifact.repository.DefaultArtifactRepository

Bug Category Details Line Priority
org.apache.maven.artifact.repository.DefaultArtifactRepository doesn't override org.apache.maven.wagon.repository.Repository.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 269-293 Medium
Class org.apache.maven.artifact.repository.DefaultArtifactRepository defines non-transient non-serializable instance field authentication BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.apache.maven.artifact.repository.DefaultArtifactRepository defines non-transient non-serializable instance field proxy BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.apache.maven.artifact.repository.DefaultArtifactRepository defines non-transient non-serializable instance field releases BAD_PRACTICE SE_BAD_FIELD Not available Medium
Class org.apache.maven.artifact.repository.DefaultArtifactRepository defines non-transient non-serializable instance field snapshots BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager

Bug Category Details Line Priority
exceptional return value of java.io.File.delete() ignored in org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager.getArtifactMetadataFromDeploymentRepository(ArtifactMetadata, ArtifactRepository, ArtifactRepository) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 451 Medium
exceptional return value of java.io.File.delete() ignored in org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager.resolve(RepositoryMetadata, RepositoryRequest) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 144 Medium
exceptional return value of java.io.File.setLastModified(long) ignored in org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager.resolve(RepositoryMetadata, RepositoryRequest) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 163 Medium
org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager.updateSnapshotMetadata(RepositoryMetadata, Map, ArtifactRepository, ArtifactRepository) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 228 Medium

org.apache.maven.artifact.resolver.WarningResolutionListener

Bug Category Details Line Priority
Unread field: org.apache.maven.artifact.resolver.WarningResolutionListener.logger PERFORMANCE URF_UNREAD_FIELD 38 Medium

org.apache.maven.artifact.versioning.ManagedVersionMap

Bug Category Details Line Priority
org.apache.maven.artifact.versioning.ManagedVersionMap.toString() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 48 Medium

org.apache.maven.profiles.Repository

Bug Category Details Line Priority
org.apache.maven.profiles.Repository defines equals and uses Object.hashCode() BAD_PRACTICE HE_EQUALS_USE_HASHCODE 88 High

org.apache.maven.profiles.RepositoryBase

Bug Category Details Line Priority
Equals method for org.apache.maven.profiles.RepositoryBase assumes the argument is of type RepositoryBase BAD_PRACTICE BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS 145 Medium
org.apache.maven.profiles.RepositoryBase defines equals and uses Object.hashCode() BAD_PRACTICE HE_EQUALS_USE_HASHCODE 145-154 High

org.apache.maven.profiles.io.xpp3.ProfilesXpp3Reader

Bug Category Details Line Priority
Private method org.apache.maven.profiles.io.xpp3.ProfilesXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 157 Medium
Private method org.apache.maven.profiles.io.xpp3.ProfilesXpp3Reader.getDateValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 245 Medium

org.apache.maven.project.DefaultProjectBuilderConfiguration

Bug Category Details Line Priority
org.apache.maven.project.DefaultProjectBuilderConfiguration.getBuildStartTime() may expose internal representation by returning DefaultProjectBuilderConfiguration.buildStartTime MALICIOUS_CODE EI_EXPOSE_REP 98 Medium
org.apache.maven.project.DefaultProjectBuilderConfiguration.setBuildStartTime(Date) may expose internal representation by storing an externally mutable object into DefaultProjectBuilderConfiguration.buildStartTime MALICIOUS_CODE EI_EXPOSE_REP2 103 Medium

org.apache.maven.project.interpolation.BuildTimestampValueSource

Bug Category Details Line Priority
new org.apache.maven.project.interpolation.BuildTimestampValueSource(Date, String) may expose internal representation by storing an externally mutable object into BuildTimestampValueSource.startTime MALICIOUS_CODE EI_EXPOSE_REP2 44 Medium

org.apache.maven.project.interpolation.StringSearchModelInterpolator$InterpolateObjectAction

Bug Category Details Line Priority
Load of known null value in org.apache.maven.project.interpolation.StringSearchModelInterpolator$InterpolateObjectAction.traverseObjectWithParents(Class, Object) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 255 Medium

org.apache.maven.repository.MetadataResolutionResult

Bug Category Details Line Priority
The method name org.apache.maven.repository.MetadataResolutionResult.ListOriginatingArtifact(Artifact) doesn't start with a lower case letter BAD_PRACTICE NM_METHOD_NAMING_CONVENTION 79-81 Medium
Unused field: org.apache.maven.repository.MetadataResolutionResult.dirtyTree PERFORMANCE UUF_UNUSED_FIELD Not available Medium
Unused field: org.apache.maven.repository.MetadataResolutionResult.resolvedGraph PERFORMANCE UUF_UNUSED_FIELD Not available Medium
Unwritten field: org.apache.maven.repository.MetadataResolutionResult.errorArtifactExceptions CORRECTNESS UWF_UNWRITTEN_FIELD 230 Medium

org.apache.maven.repository.legacy.DefaultUpdateCheckManager

Bug Category Details Line Priority
exceptional return value of java.io.File.delete() ignored in org.apache.maven.repository.legacy.DefaultUpdateCheckManager.touch(Artifact, ArtifactRepository, String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 175 Medium

org.apache.maven.repository.legacy.DefaultWagonManager

Bug Category Details Line Priority
exceptional return value of java.io.File.delete() ignored in org.apache.maven.repository.legacy.DefaultWagonManager.getRemoteFile(ArtifactRepository, File, String, TransferListener, String, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 508 Medium
exceptional return value of java.io.File.setLastModified(long) ignored in org.apache.maven.repository.legacy.DefaultWagonManager.getRemoteFile(ArtifactRepository, File, String, TransferListener, String, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 370 Medium
exceptional return value of java.io.File.delete() ignored in org.apache.maven.repository.legacy.DefaultWagonManager.verifyChecksum(ChecksumObserver, File, File, String, String, Wagon) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 733 Medium
org.apache.maven.repository.legacy.DefaultWagonManager.putRemoteFile(ArtifactRepository, File, String, TransferListener) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 588 Medium

org.apache.maven.repository.metadata.DefaultClasspathTransformation

Bug Category Details Line Priority
Dead store to md in org.apache.maven.repository.metadata.DefaultClasspathTransformation.transform(MetadataGraph, ArtifactScopeEnum, boolean) STYLE DLS_DEAD_LOCAL_STORE 73 Medium

org.apache.maven.repository.metadata.DefaultClasspathTransformation$ClasspathGraphVisitor

Bug Category Details Line Priority
Should org.apache.maven.repository.metadata.DefaultClasspathTransformation$ClasspathGraphVisitor be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 101-175 Medium

org.apache.maven.repository.metadata.MetadataGraphEdge

Bug Category Details Line Priority
org.apache.maven.repository.metadata.MetadataGraphEdge defines equals and uses Object.hashCode() BAD_PRACTICE HE_EQUALS_USE_HASHCODE 86-94 High
Possible null pointer dereference of o1 on branch that might be infeasible in org.apache.maven.repository.metadata.MetadataGraphEdge.objectsEqual(Object, Object) STYLE NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE 76 Medium

org.apache.maven.repository.metadata.MetadataGraphVertex

Bug Category Details Line Priority
Possible null pointer dereference of s1 on branch that might be infeasible in org.apache.maven.repository.metadata.MetadataGraphVertex.compareStrings(String, String) STYLE NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE 107 Medium

org.apache.maven.repository.metadata.MetadataTreeNode

Bug Category Details Line Priority
org.apache.maven.repository.metadata.MetadataTreeNode.getChildren() may expose internal representation by returning MetadataTreeNode.children MALICIOUS_CODE EI_EXPOSE_REP 138 Medium
org.apache.maven.repository.metadata.MetadataTreeNode.setChildren(MetadataTreeNode[]) may expose internal representation by storing an externally mutable object into MetadataTreeNode.children MALICIOUS_CODE EI_EXPOSE_REP2 143 Medium

org.apache.maven.usability.plugin.ExpressionDocumenter

Bug Category Details Line Priority
Incorrect lazy initialization and update of static field org.apache.maven.usability.plugin.ExpressionDocumenter.expressionDocumentation in org.apache.maven.usability.plugin.ExpressionDocumenter.load() MT_CORRECTNESS LI_LAZY_INIT_UPDATE_STATIC 51-53 High

org.apache.maven.usability.plugin.io.xpp3.ParamdocXpp3Reader

Bug Category Details Line Priority
Private method org.apache.maven.usability.plugin.io.xpp3.ParamdocXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 150 Medium
Private method org.apache.maven.usability.plugin.io.xpp3.ParamdocXpp3Reader.getDateValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 238 Medium