Checkstyle Results

The following document contains the results of Checkstyle 9.3 with config/maven_checks_nocodestyle.xml ruleset.

Summary

Files
 Info
 Warnings
 Errors
310 75 61 29

Files

File
 I
 W
 E
org/apache/maven/scm/ChangeSet.java 0 3 0
org/apache/maven/scm/CommandParameter.java 23 0 0
org/apache/maven/scm/PlexusJUnit4TestSupport.java 1 4 0
org/apache/maven/scm/ScmRequest.java 1 0 0
org/apache/maven/scm/ScmResult.java 1 1 0
org/apache/maven/scm/ScmTckTestCase.java 0 13 0
org/apache/maven/scm/ScmTestCase.java 1 0 0
org/apache/maven/scm/command/AbstractCommand.java 1 0 0
org/apache/maven/scm/command/changelog/ChangeLogSet.java 1 0 0
org/apache/maven/scm/command/checkin/AbstractCheckInCommand.java 1 0 0
org/apache/maven/scm/command/info/InfoItem.java 0 1 0
org/apache/maven/scm/manager/AbstractScmManager.java 1 0 0
org/apache/maven/scm/plugin/AbstractScmMojo.java 4 2 0
org/apache/maven/scm/plugin/BootstrapMojo.java 0 1 0
org/apache/maven/scm/provider/AbstractScmProvider.java 1 4 0
org/apache/maven/scm/provider/ScmProviderStub.java 0 6 0
org/apache/maven/scm/provider/git/command/changelog/GitChangeLogCommandTckTest.java 1 0 0
org/apache/maven/scm/provider/git/command/checkout/GitSshCheckOutCommandTckTest.java 4 0 1
org/apache/maven/scm/provider/git/gitexe/command/AbstractFileCheckingConsumer.java 2 0 0
org/apache/maven/scm/provider/git/gitexe/command/AnonymousCommandLine.java 1 0 0
org/apache/maven/scm/provider/git/gitexe/command/GitCommandLineUtils.java 1 1 0
org/apache/maven/scm/provider/git/gitexe/command/branch/GitBranchCommand.java 0 3 0
org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java 0 0 5
org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumer.java 0 1 0
org/apache/maven/scm/provider/git/gitexe/command/diff/GitDiffCommand.java 0 6 0
org/apache/maven/scm/provider/git/gitexe/command/info/GitInfoCommand.java 1 0 0
org/apache/maven/scm/provider/git/gitexe/command/info/GitInfoConsumer.java 0 1 0
org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumer.java 0 0 4
org/apache/maven/scm/provider/git/gitexe/command/update/GitUpdateCommand.java 0 6 0
org/apache/maven/scm/provider/git/jgit/command/JGitUtils.java 0 1 0
org/apache/maven/scm/provider/git/jgit/command/changelog/JGitChangeLogCommand.java 0 0 2
org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommand.java 3 0 0
org/apache/maven/scm/provider/git/repository/GitScmProviderRepository.java 0 0 1
org/apache/maven/scm/provider/git/util/GitUtil.java 2 0 0
org/apache/maven/scm/provider/hg/HgUtils.java 1 0 0
org/apache/maven/scm/provider/hg/command/HgCommandConstants.java 11 0 0
org/apache/maven/scm/provider/hg/command/blame/HgBlameCommand.java 1 0 0
org/apache/maven/scm/provider/hg/command/changelog/HgChangeLogCommand.java 0 0 3
org/apache/maven/scm/provider/hg/command/info/HgInfoConsumer.java 0 1 0
org/apache/maven/scm/provider/svn/AbstractSvnScmProvider.java 1 0 0
org/apache/maven/scm/provider/svn/SvnTagBranchUtils.java 5 2 0
org/apache/maven/scm/provider/svn/repository/SvnScmProviderRepository.java 0 3 0
org/apache/maven/scm/provider/svn/svnexe/command/AbstractFileCheckingConsumer.java 2 0 0
org/apache/maven/scm/provider/svn/svnexe/command/blame/SvnBlameConsumer.java 0 0 4
org/apache/maven/scm/provider/svn/svnexe/command/changelog/SvnChangeLogCommand.java 0 0 2
org/apache/maven/scm/provider/svn/svnexe/command/changelog/SvnChangeLogConsumer.java 0 1 2
org/apache/maven/scm/provider/svn/util/SvnUtil.java 2 0 0
org/apache/maven/scm/tck/command/blame/BlameCommandTckTest.java 0 0 2
org/apache/maven/scm/tck/command/changelog/ChangeLogCommandTckTest.java 0 0 1
org/apache/maven/scm/tck/command/update/UpdateCommandTckTest.java 0 0 2
org/apache/maven/scm/util/AbstractConsumer.java 1 0 0

Rules

Category Rule Violations Severity
coding HiddenField
  • ignoreConstructorParameter: "true"
  • ignoreSetter: "true"
11
 Warning
InnerAssignment 11
 Error
MagicNumber
  • ignoreNumbers: "-4, -3, -2, -1, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 31, 32, 37, 64, 100, 128, 256, 512, 1000, 1024"
9
 Error
javadoc JavadocMethod
  • accessModifiers: "public, protected"
50
 Warning
JavadocVariable
  • scope: "protected"
75
 Info
sizes ParameterNumber 9
 Error

Details

org/apache/maven/scm/ChangeSet.java

Severity Category Rule Message Line
 Warning
coding HiddenField 'date' hides a field. 302
 Warning
coding HiddenField 'tags' hides a field. 445
 Warning
coding HiddenField 'tags' hides a field. 520

org/apache/maven/scm/CommandParameter.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 30
 Info
javadoc JavadocVariable Missing a Javadoc comment. 32
 Info
javadoc JavadocVariable Missing a Javadoc comment. 34
 Info
javadoc JavadocVariable Missing a Javadoc comment. 36
 Info
javadoc JavadocVariable Missing a Javadoc comment. 38
 Info
javadoc JavadocVariable Missing a Javadoc comment. 40
 Info
javadoc JavadocVariable Missing a Javadoc comment. 42
 Info
javadoc JavadocVariable Missing a Javadoc comment. 44
 Info
javadoc JavadocVariable Missing a Javadoc comment. 46
 Info
javadoc JavadocVariable Missing a Javadoc comment. 48
 Info
javadoc JavadocVariable Missing a Javadoc comment. 50
 Info
javadoc JavadocVariable Missing a Javadoc comment. 52
 Info
javadoc JavadocVariable Missing a Javadoc comment. 54
 Info
javadoc JavadocVariable Missing a Javadoc comment. 56
 Info
javadoc JavadocVariable Missing a Javadoc comment. 58
 Info
javadoc JavadocVariable Missing a Javadoc comment. 60
 Info
javadoc JavadocVariable Missing a Javadoc comment. 62
 Info
javadoc JavadocVariable Missing a Javadoc comment. 64
 Info
javadoc JavadocVariable Missing a Javadoc comment. 66
 Info
javadoc JavadocVariable Missing a Javadoc comment. 68
 Info
javadoc JavadocVariable Missing a Javadoc comment. 70
 Info
javadoc JavadocVariable Missing a Javadoc comment. 72
 Info
javadoc JavadocVariable Missing a Javadoc comment. 74

org/apache/maven/scm/PlexusJUnit4TestSupport.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 53
 Warning
javadoc JavadocMethod @return tag should be present and have description. 121
 Warning
javadoc JavadocMethod @return tag should be present and have description. 176
 Warning
coding HiddenField 'basedir' hides a field. 225
 Warning
coding HiddenField 'basedir' hides a field. 240

org/apache/maven/scm/ScmRequest.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 44

org/apache/maven/scm/ScmResult.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 40
 Warning
coding HiddenField 'commandOutput' hides a field. 111

org/apache/maven/scm/ScmTckTestCase.java

Severity Category Rule Message Line
 Warning
javadoc JavadocMethod @return tag should be present and have description. 165
 Warning
javadoc JavadocMethod @return tag should be present and have description. 176
 Warning
javadoc JavadocMethod Expected @param tag for 'workingDirectory'. 176
 Warning
javadoc JavadocMethod Expected @param tag for 'repository'. 176
 Warning
javadoc JavadocMethod @return tag should be present and have description. 189
 Warning
javadoc JavadocMethod Expected @param tag for 'workingDirectory'. 189
 Warning
javadoc JavadocMethod Expected @param tag for 'repository'. 189
 Warning
javadoc JavadocMethod @return tag should be present and have description. 202
 Warning
javadoc JavadocMethod Expected @param tag for 'workingDirectory'. 202
 Warning
javadoc JavadocMethod Expected @param tag for 'repository'. 202
 Warning
javadoc JavadocMethod Expected @param tag for 'workingDirectory'. 215
 Warning
javadoc JavadocMethod Expected @param tag for 'file'. 215
 Warning
javadoc JavadocMethod Expected @param tag for 'repository'. 215

org/apache/maven/scm/ScmTestCase.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 56

org/apache/maven/scm/command/AbstractCommand.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 35

org/apache/maven/scm/command/changelog/ChangeLogSet.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 33

org/apache/maven/scm/command/checkin/AbstractCheckInCommand.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 37

org/apache/maven/scm/command/info/InfoItem.java

Severity Category Rule Message Line
 Warning
coding HiddenField 'url' hides a field. 60

org/apache/maven/scm/manager/AbstractScmManager.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 69

org/apache/maven/scm/plugin/AbstractScmMojo.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 64
 Info
javadoc JavadocVariable Missing a Javadoc comment. 66
 Info
javadoc JavadocVariable Missing a Javadoc comment. 68
 Info
javadoc JavadocVariable Missing a Javadoc comment. 70
 Warning
coding HiddenField 'includes' hides a field. 433
 Warning
coding HiddenField 'excludes' hides a field. 442

org/apache/maven/scm/plugin/BootstrapMojo.java

Severity Category Rule Message Line
 Warning
coding HiddenField 'goalsDirectory' hides a field. 160

org/apache/maven/scm/provider/AbstractScmProvider.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 71
 Warning
javadoc JavadocMethod @return tag should be present and have description. 174
 Warning
javadoc JavadocMethod Expected @param tag for 'repository'. 174
 Warning
javadoc JavadocMethod Expected @param tag for 'fileSet'. 174
 Warning
javadoc JavadocMethod Expected @param tag for 'parameters'. 174

org/apache/maven/scm/provider/ScmProviderStub.java

Severity Category Rule Message Line
 Warning
javadoc JavadocMethod Expected @param tag for 'repository'. 563
 Warning
javadoc JavadocMethod Expected @param tag for 'fileSet'. 564
 Warning
javadoc JavadocMethod Expected @param tag for 'tag'. 565
 Warning
javadoc JavadocMethod Expected @param tag for 'lastUpdate'. 566
 Warning
javadoc JavadocMethod Expected @param tag for 'datePattern'. 567
 Warning
javadoc JavadocMethod Expected @param tag for 'runChangelog'. 568

org/apache/maven/scm/provider/git/command/changelog/GitChangeLogCommandTckTest.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 47

org/apache/maven/scm/provider/git/command/checkout/GitSshCheckOutCommandTckTest.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 62
 Info
javadoc JavadocVariable Missing a Javadoc comment. 63
 Info
javadoc JavadocVariable Missing a Javadoc comment. 64
 Info
javadoc JavadocVariable Missing a Javadoc comment. 66
 Error
coding MagicNumber '2048' is a magic number. 71

org/apache/maven/scm/provider/git/gitexe/command/AbstractFileCheckingConsumer.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 35
 Info
javadoc JavadocVariable Missing a Javadoc comment. 39

org/apache/maven/scm/provider/git/gitexe/command/AnonymousCommandLine.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 32

org/apache/maven/scm/provider/git/gitexe/command/GitCommandLineUtils.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 51
 Warning
javadoc JavadocMethod Expected @param tag for 'repository'. 105

org/apache/maven/scm/provider/git/gitexe/command/branch/GitBranchCommand.java

Severity Category Rule Message Line
 Warning
javadoc JavadocMethod @return tag should be present and have description. 119
 Warning
javadoc JavadocMethod Expected @param tag for 'repository'. 119
 Warning
javadoc JavadocMethod Expected @param tag for 'fileSet'. 119

org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogCommand.java

Severity Category Rule Message Line
 Error
sizes ParameterNumber More than 7 parameters (found 8). 101
 Error
sizes ParameterNumber More than 7 parameters (found 9). 142
 Error
sizes ParameterNumber More than 7 parameters (found 10). 157
 Error
sizes ParameterNumber More than 7 parameters (found 8). 228
 Error
sizes ParameterNumber More than 7 parameters (found 9). 241

org/apache/maven/scm/provider/git/gitexe/command/changelog/GitChangeLogConsumer.java

Severity Category Rule Message Line
 Warning
javadoc JavadocMethod Expected @param tag for 'userDateFormat'. 163

org/apache/maven/scm/provider/git/gitexe/command/diff/GitDiffCommand.java

Severity Category Rule Message Line
 Warning
javadoc JavadocMethod @return tag should be present and have description. 75
 Warning
javadoc JavadocMethod Expected @param tag for 'workingDirectory'. 76
 Warning
javadoc JavadocMethod Expected @param tag for 'startVersion'. 76
 Warning
javadoc JavadocMethod Expected @param tag for 'endVersion'. 76
 Warning
javadoc JavadocMethod @return tag should be present and have description. 100
 Warning
javadoc JavadocMethod Expected @param tag for 'sha1'. 100

org/apache/maven/scm/provider/git/gitexe/command/info/GitInfoCommand.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 40

org/apache/maven/scm/provider/git/gitexe/command/info/GitInfoConsumer.java

Severity Category Rule Message Line
 Warning
javadoc JavadocMethod Expected @param tag for 'line'. 49

org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumer.java

Severity Category Rule Message Line
 Error
coding InnerAssignment Inner assignments should be avoided. 156
 Error
coding InnerAssignment Inner assignments should be avoided. 159
 Error
coding InnerAssignment Inner assignments should be avoided. 162
 Error
coding InnerAssignment Inner assignments should be avoided. 165

org/apache/maven/scm/provider/git/gitexe/command/update/GitUpdateCommand.java

Severity Category Rule Message Line
 Warning
javadoc JavadocMethod @return tag should be present and have description. 111
 Warning
javadoc JavadocMethod Expected @param tag for 'repository'. 112
 Warning
javadoc JavadocMethod Expected @param tag for 'workingDirectory'. 112
 Warning
javadoc JavadocMethod Expected @param tag for 'scmVersion'. 112
 Warning
javadoc JavadocMethod Expected @param tag for 'repository'. 130
 Warning
javadoc JavadocMethod Expected @param tag for 'workingDirectory'. 130

org/apache/maven/scm/provider/git/jgit/command/JGitUtils.java

Severity Category Rule Message Line
 Warning
javadoc JavadocMethod @return tag should be present and have description. 99

org/apache/maven/scm/provider/git/jgit/command/changelog/JGitChangeLogCommand.java

Severity Category Rule Message Line
 Error
sizes ParameterNumber More than 7 parameters (found 8). 88
 Error
sizes ParameterNumber More than 7 parameters (found 9). 102

org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommand.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 67
 Info
javadoc JavadocVariable Missing a Javadoc comment. 69
 Info
javadoc JavadocVariable Missing a Javadoc comment. 71

org/apache/maven/scm/provider/git/repository/GitScmProviderRepository.java

Severity Category Rule Message Line
 Error
coding InnerAssignment Inner assignments should be avoided. 145

org/apache/maven/scm/provider/git/util/GitUtil.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 34
 Info
javadoc JavadocVariable Missing a Javadoc comment. 36

org/apache/maven/scm/provider/hg/HgUtils.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 50

org/apache/maven/scm/provider/hg/command/HgCommandConstants.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 130
 Info
javadoc JavadocVariable Missing a Javadoc comment. 132
 Info
javadoc JavadocVariable Missing a Javadoc comment. 134
 Info
javadoc JavadocVariable Missing a Javadoc comment. 136
 Info
javadoc JavadocVariable Missing a Javadoc comment. 138
 Info
javadoc JavadocVariable Missing a Javadoc comment. 140
 Info
javadoc JavadocVariable Missing a Javadoc comment. 142
 Info
javadoc JavadocVariable Missing a Javadoc comment. 144
 Info
javadoc JavadocVariable Missing a Javadoc comment. 146
 Info
javadoc JavadocVariable Missing a Javadoc comment. 148
 Info
javadoc JavadocVariable Missing a Javadoc comment. 150

org/apache/maven/scm/provider/hg/command/blame/HgBlameCommand.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 35

org/apache/maven/scm/provider/hg/command/changelog/HgChangeLogCommand.java

Severity Category Rule Message Line
 Error
coding MagicNumber '60' is a magic number. 85
 Error
coding MagicNumber '60' is a magic number. 85
 Error
coding MagicNumber '24' is a magic number. 85

org/apache/maven/scm/provider/hg/command/info/HgInfoConsumer.java

Severity Category Rule Message Line
 Warning
javadoc JavadocMethod Expected @param tag for 'line'. 39

org/apache/maven/scm/provider/svn/AbstractSvnScmProvider.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 73

org/apache/maven/scm/provider/svn/SvnTagBranchUtils.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 34
 Info
javadoc JavadocVariable Missing a Javadoc comment. 36
 Info
javadoc JavadocVariable Missing a Javadoc comment. 38
 Info
javadoc JavadocVariable Missing a Javadoc comment. 40
 Info
javadoc JavadocVariable Missing a Javadoc comment. 42
 Warning
javadoc JavadocMethod @return tag should be present and have description. 248
 Warning
javadoc JavadocMethod Expected @param tag for 'version'. 248

org/apache/maven/scm/provider/svn/repository/SvnScmProviderRepository.java

Severity Category Rule Message Line
 Warning
javadoc JavadocMethod @return tag should be present and have description. 68
 Warning
javadoc JavadocMethod @return tag should be present and have description. 89
 Warning
coding HiddenField 'url' hides a field. 120

org/apache/maven/scm/provider/svn/svnexe/command/AbstractFileCheckingConsumer.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 35
 Info
javadoc JavadocVariable Missing a Javadoc comment. 39

org/apache/maven/scm/provider/svn/svnexe/command/blame/SvnBlameConsumer.java

Severity Category Rule Message Line
 Error
coding InnerAssignment Inner assignments should be avoided. 66
 Error
coding InnerAssignment Inner assignments should be avoided. 69
 Error
coding InnerAssignment Inner assignments should be avoided. 71
 Error
coding InnerAssignment Inner assignments should be avoided. 73

org/apache/maven/scm/provider/svn/svnexe/command/changelog/SvnChangeLogCommand.java

Severity Category Rule Message Line
 Error
sizes ParameterNumber More than 7 parameters (found 9). 118
 Error
sizes ParameterNumber More than 7 parameters (found 8). 185

org/apache/maven/scm/provider/svn/svnexe/command/changelog/SvnChangeLogConsumer.java

Severity Category Rule Message Line
 Warning
javadoc JavadocMethod Expected @param tag for 'userDateFormat'. 130
 Error
coding InnerAssignment Inner assignments should be avoided. 205
 Error
coding InnerAssignment Inner assignments should be avoided. 207

org/apache/maven/scm/provider/svn/util/SvnUtil.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 34
 Info
javadoc JavadocVariable Missing a Javadoc comment. 36

org/apache/maven/scm/tck/command/blame/BlameCommandTckTest.java

Severity Category Rule Message Line
 Error
coding MagicNumber '2000' is a magic number. 70
 Error
coding MagicNumber '2000' is a magic number. 80

org/apache/maven/scm/tck/command/changelog/ChangeLogCommandTckTest.java

Severity Category Rule Message Line
 Error
coding MagicNumber '2000' is a magic number. 84

org/apache/maven/scm/tck/command/update/UpdateCommandTckTest.java

Severity Category Rule Message Line
 Error
coding MagicNumber '1000000' is a magic number. 131
 Error
coding MagicNumber '5000' is a magic number. 135

org/apache/maven/scm/util/AbstractConsumer.java

Severity Category Rule Message Line
 Info
javadoc JavadocVariable Missing a Javadoc comment. 36