Maven SCM AccuRev Provider - FindBugs Bug Detector Report

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 2.0.1

Threshold is medium

Effort is min

Summary

Classes	Bugs	Errors	Missing Classes
48	12	0	0

Files

Class	Bugs
org.apache.maven.scm.provider.accurev.AccuRev	1
org.apache.maven.scm.provider.accurev.AccuRevScmProviderRepository	2
org.apache.maven.scm.provider.accurev.AccuRevVersion	1
org.apache.maven.scm.provider.accurev.Stream	2
org.apache.maven.scm.provider.accurev.Transaction	2
org.apache.maven.scm.provider.accurev.cli.AccuRevCommandLine	2
org.apache.maven.scm.provider.accurev.command.AbstractAccuRevExtractSourceCommand	1
org.apache.maven.scm.provider.accurev.util.QuotedPropertyParser	1

org.apache.maven.scm.provider.accurev.AccuRev

Bug	Category	Details	Line	Priority
org.apache.maven.scm.provider.accurev.AccuRev.ACCUREV_TIME_SPEC is a static field of type java.text.DateFormat, which isn't thread safe	MT_CORRECTNESS	STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE	Not available	High

org.apache.maven.scm.provider.accurev.AccuRevScmProviderRepository

Bug	Category	Details	Line	Priority
Call to method of static java.text.DateFormat in org.apache.maven.scm.provider.accurev.AccuRevScmProviderRepository.formatTimeSpec(Date)	MT_CORRECTNESS	STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE	361	Medium
Call to method of static java.text.DateFormat in org.apache.maven.scm.provider.accurev.AccuRevScmProviderRepository.getRevision(String, Date)	MT_CORRECTNESS	STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE	258	Medium

org.apache.maven.scm.provider.accurev.AccuRevVersion

Bug	Category	Details	Line	Priority
Call to method of static java.text.DateFormat in new org.apache.maven.scm.provider.accurev.AccuRevVersion(String, Date)	MT_CORRECTNESS	STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE	47	Medium

org.apache.maven.scm.provider.accurev.Stream

Bug	Category	Details	Line	Priority
org.apache.maven.scm.provider.accurev.Stream.getStartDate() may expose internal representation by returning Stream.startDate	MALICIOUS_CODE	EI_EXPOSE_REP	146	Medium
new org.apache.maven.scm.provider.accurev.Stream(String, long, String, long, String, Date, String) may expose internal representation by storing an externally mutable object into Stream.startDate	MALICIOUS_CODE	EI_EXPOSE_REP2	48	Medium

org.apache.maven.scm.provider.accurev.Transaction

Bug	Category	Details	Line	Priority
org.apache.maven.scm.provider.accurev.Transaction.getWhen() may expose internal representation by returning Transaction.when	MALICIOUS_CODE	EI_EXPOSE_REP	167	Medium
new org.apache.maven.scm.provider.accurev.Transaction(Long, Date, String, String) may expose internal representation by storing an externally mutable object into Transaction.when	MALICIOUS_CODE	EI_EXPOSE_REP2	118	Medium

org.apache.maven.scm.provider.accurev.cli.AccuRevCommandLine

Bug	Category	Details	Line	Priority
Hard coded reference to an absolute pathname in org.apache.maven.scm.provider.accurev.cli.AccuRevCommandLine.popExternal(File, String, String, Collection)	STYLE	DMI_HARDCODED_ABSOLUTE_FILENAME	561	Medium
Found reliance on default encoding in org.apache.maven.scm.provider.accurev.cli.AccuRevCommandLine.login(String, String): String.getBytes()	I18N	DM_DEFAULT_ENCODING	664	High

org.apache.maven.scm.provider.accurev.command.AbstractAccuRevExtractSourceCommand

Bug	Category	Details	Line	Priority
exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.scm.provider.accurev.command.AbstractAccuRevExtractSourceCommand.executeAccurevCommand(AccuRevScmProviderRepository, ScmFileSet, CommandParameters)	BAD_PRACTICE	RV_RETURN_VALUE_IGNORED_BAD_PRACTICE	65	Medium

org.apache.maven.scm.provider.accurev.util.QuotedPropertyParser

Bug	Category	Details	Line	Priority
Switch statement found in org.apache.maven.scm.provider.accurev.util.QuotedPropertyParser.parse(CharSequence, Map) where default case is missing	STYLE	SF_SWITCH_NO_DEFAULT	60-80	Medium