FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 112 |
47 |
0 |
0 |
org.apache.maven.shared.release.DefaultReleaseManager
| Bug |
Category |
Details |
Line |
Priority |
| Null passed for non-null parameter of java.util.Collections.unmodifiableList(List) in org.apache.maven.shared.release.DefaultReleaseManager.getGoalPhases(Strategy, String) |
CORRECTNESS |
NP_NULL_PARAM_DEREF |
696 |
High |
org.apache.maven.shared.release.config.ModelloReleaseDescriptor
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference of that on branch that might be infeasible in org.apache.maven.shared.release.config.ModelloReleaseDescriptor.compareScmCollections(Map) |
STYLE |
NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE |
2275 |
Medium |
| Redundant nullcheck of org.apache.maven.shared.release.config.ModelloReleaseDescriptor.checkModificationExcludes, which is known to be non-null in org.apache.maven.shared.release.config.ModelloReleaseDescriptor.equals(Object) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
2153 |
Medium |
| Redundant nullcheck of org.apache.maven.shared.release.config.ModelloReleaseDescriptor.originalScmInfo, which is known to be non-null in org.apache.maven.shared.release.config.ModelloReleaseDescriptor.equals(Object) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
2166 |
Medium |
org.apache.maven.shared.release.config.PropertiesReleaseDescriptorStore
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.shared.release.config.PropertiesReleaseDescriptorStore.delete(ReleaseDescriptor) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
149 |
Medium |
org.apache.maven.shared.release.config.io.xpp3.ReleaseDescriptorXpp3Reader
| Bug |
Category |
Details |
Line |
Priority |
| Boxing/unboxing to parse a primitive org.apache.maven.shared.release.config.io.xpp3.ReleaseDescriptorXpp3Reader.getIntegerValue(String, String, XmlPullParser, boolean) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
391 |
High |
| Boxing/unboxing to parse a primitive org.apache.maven.shared.release.config.io.xpp3.ReleaseDescriptorXpp3Reader.getLongValue(String, String, XmlPullParser, boolean) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
421 |
High |
| Private method org.apache.maven.shared.release.config.io.xpp3.ReleaseDescriptorXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
176 |
Medium |
| Private method org.apache.maven.shared.release.config.io.xpp3.ReleaseDescriptorXpp3Reader.getDateValue(String, String, XmlPullParser) is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
264 |
Medium |
org.apache.maven.shared.release.config.io.xpp3.ReleaseDescriptorXpp3Writer
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: org.apache.maven.shared.release.config.io.xpp3.ReleaseDescriptorXpp3Writer.fileComment |
PERFORMANCE |
URF_UNREAD_FIELD |
41 |
Medium |
org.apache.maven.shared.release.exec.ForkedMavenExecutor
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.shared.release.exec.ForkedMavenExecutor.executeGoals(File, List, ReleaseEnvironment, boolean, String, String, ReleaseResult): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
82 |
High |
org.apache.maven.shared.release.exec.InvokerMavenExecutor
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.shared.release.exec.InvokerMavenExecutor.executeGoals(File, List, ReleaseEnvironment, boolean, String, String, ReleaseResult): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
368 |
High |
org.apache.maven.shared.release.exec.RawStreamPumper
| Bug |
Category |
Details |
Line |
Priority |
| Useless condition: it's known that i != -1 at this point |
STYLE |
UC_USELESS_CONDITION |
140 |
High |
org.apache.maven.shared.release.exec.TeeOutputStream
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in new org.apache.maven.shared.release.exec.TeeOutputStream(OutputStream, String): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
57 |
High |
| Found reliance on default encoding in org.apache.maven.shared.release.exec.TeeOutputStream.getContent(): java.io.ByteArrayOutputStream.toString() |
I18N |
DM_DEFAULT_ENCODING |
108 |
High |
| Found reliance on default encoding in org.apache.maven.shared.release.exec.TeeOutputStream.toString(): java.io.ByteArrayOutputStream.toString() |
I18N |
DM_DEFAULT_ENCODING |
98 |
High |
org.apache.maven.shared.release.phase.AbstractBackupPomsPhase
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.shared.release.phase.AbstractBackupPomsPhase.deletePomBackup(MavenProject) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
68 |
Medium |
| Unread field: org.apache.maven.shared.release.phase.AbstractBackupPomsPhase.backupSuffix; should this field be static? |
PERFORMANCE |
SS_SHOULD_BE_STATIC |
35 |
Medium |
org.apache.maven.shared.release.phase.AbstractRewritePomsPhase
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to parentVersion in org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.transformDocument(MavenProject, Model, ReleaseDescriptor, ScmRepository, ReleaseResult, boolean) |
STYLE |
DLS_DEAD_LOCAL_STORE |
279 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.shared.release.phase.AbstractRewritePomsPhase.clean(List) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
190 |
Medium |
org.apache.maven.shared.release.phase.AbstractScmCommitPhase
org.apache.maven.shared.release.phase.CheckPomPhase
| Bug |
Category |
Details |
Line |
Priority |
| Read of unwritten field scmRepositoryConfigurator in org.apache.maven.shared.release.phase.CheckPomPhase.execute(ReleaseDescriptor, ReleaseEnvironment, List) |
CORRECTNESS |
NP_UNWRITTEN_FIELD |
76 |
Medium |
| Unwritten field: org.apache.maven.shared.release.phase.CheckPomPhase.scmRepositoryConfigurator |
CORRECTNESS |
UWF_UNWRITTEN_FIELD |
76 |
Medium |
org.apache.maven.shared.release.phase.CheckoutProjectFromScm
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.release.phase.CheckoutProjectFromScm.performCheckout(ReleaseDescriptor, ReleaseEnvironment, List) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
208 |
Medium |
org.apache.maven.shared.release.phase.GenerateReleasePomsPhase
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to projectVersion in org.apache.maven.shared.release.phase.GenerateReleasePomsPhase.createReleaseModel(MavenProject, ReleaseDescriptor, ReleaseEnvironment, ReleaseResult) |
STYLE |
DLS_DEAD_LOCAL_STORE |
228 |
Medium |
org.apache.maven.shared.release.phase.InputVariablesPhase
| Bug |
Category |
Details |
Line |
Priority |
| Unwritten field: org.apache.maven.shared.release.phase.InputVariablesPhase.defaultNamingPolicy |
CORRECTNESS |
UWF_UNWRITTEN_FIELD |
190 |
Medium |
org.apache.maven.shared.release.phase.RemoveReleasePomsPhase
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.shared.release.phase.RemoveReleasePomsPhase.removeReleasePomsFromFilesystem(boolean, ReleaseResult, List) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
120 |
Medium |
org.apache.maven.shared.release.phase.ScmCommitDevelopmentPhase
| Bug |
Category |
Details |
Line |
Priority |
| Unwritten field: org.apache.maven.shared.release.phase.ScmCommitDevelopmentPhase.rollbackMessageFormat |
CORRECTNESS |
UWF_UNWRITTEN_FIELD |
99 |
Medium |
org.apache.maven.shared.release.transform.jdom2.JDomDependency
| Bug |
Category |
Details |
Line |
Priority |
| Class org.apache.maven.shared.release.transform.jdom2.JDomDependency defines non-transient non-serializable instance field coordinate |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| org.apache.maven.shared.release.transform.jdom2.JDomMavenCoordinate stored into non-transient field JDomDependency.coordinate |
BAD_PRACTICE |
SE_BAD_FIELD_STORE |
46 |
Medium |
org.apache.maven.shared.release.transform.jdom2.JDomExtension
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.shared.release.transform.jdom2.JDomExtension doesn't override org.apache.maven.model.Extension.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
| Class org.apache.maven.shared.release.transform.jdom2.JDomExtension defines non-transient non-serializable instance field coordinate |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| org.apache.maven.shared.release.transform.jdom2.JDomMavenCoordinate stored into non-transient field JDomExtension.coordinate |
BAD_PRACTICE |
SE_BAD_FIELD_STORE |
43 |
Medium |
org.apache.maven.shared.release.transform.jdom2.JDomModel
| Bug |
Category |
Details |
Line |
Priority |
| Class org.apache.maven.shared.release.transform.jdom2.JDomModel defines non-transient non-serializable instance field modelBase |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
org.apache.maven.shared.release.transform.jdom2.JDomPlugin
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.shared.release.transform.jdom2.JDomPlugin doesn't override org.apache.maven.model.Plugin.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
| Class org.apache.maven.shared.release.transform.jdom2.JDomPlugin defines non-transient non-serializable instance field coordinate |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| org.apache.maven.shared.release.transform.jdom2.JDomMavenCoordinate stored into non-transient field JDomPlugin.coordinate |
BAD_PRACTICE |
SE_BAD_FIELD_STORE |
52 |
Medium |
org.apache.maven.shared.release.transform.jdom2.JDomProfile
| Bug |
Category |
Details |
Line |
Priority |
| Class org.apache.maven.shared.release.transform.jdom2.JDomProfile defines non-transient non-serializable instance field modelBase |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
org.apache.maven.shared.release.transform.jdom2.JDomProperties
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.shared.release.transform.jdom2.JDomProperties doesn't override java.util.Hashtable.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
| org.apache.maven.shared.release.transform.jdom2.JDomProperties.getProperty(String, String) is unsynchronized, org.apache.maven.shared.release.transform.jdom2.JDomProperties.setProperty(String, String) is synchronized |
MT_CORRECTNESS |
UG_SYNC_SET_UNSYNC_GET |
141 |
Medium |
org.apache.maven.shared.release.transform.jdom2.JDomReportPlugin
| Bug |
Category |
Details |
Line |
Priority |
| Class org.apache.maven.shared.release.transform.jdom2.JDomReportPlugin defines non-transient non-serializable instance field coordinate |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| org.apache.maven.shared.release.transform.jdom2.JDomMavenCoordinate stored into non-transient field JDomReportPlugin.coordinate |
BAD_PRACTICE |
SE_BAD_FIELD_STORE |
48 |
Medium |
org.apache.maven.shared.release.util.PomFinder
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.apache.maven.shared.release.util.PomFinder.findMatchingPom(File) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
154 |
Medium |
org.apache.maven.shared.release.versions.DefaultVersionInfo
| Bug |
Category |
Details |
Line |
Priority |
| Boxing/unboxing to parse a primitive org.apache.maven.shared.release.versions.DefaultVersionInfo.incrementVersionString(String) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
291 |
High |
