FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
121 14 0 0

Files

Class Bugs
org.apache.maven.model.building.DefaultModelBuilder 3
org.apache.maven.model.building.DefaultModelBuildingRequest 4
org.apache.maven.model.building.ModelBuildingException 1
org.apache.maven.model.building.Result$2 1
org.apache.maven.model.building.Result$3 1
org.apache.maven.model.building.Result$4 1
org.apache.maven.model.io.DefaultModelReader 1
org.apache.maven.model.io.DefaultModelWriter 1
org.apache.maven.model.superpom.DefaultSuperPomProvider 1

org.apache.maven.model.building.DefaultModelBuilder

Bug Category Details Line Priority
org.apache.maven.model.building.DefaultModelBuilder.build(ModelBuildingRequest) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 360 Medium
org.apache.maven.model.building.DefaultModelBuilder.importDependencyManagement(Model, ModelBuildingRequest, DefaultModelProblemCollector, Collection) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 1202 Medium
org.apache.maven.model.building.DefaultModelBuilder.checkPluginVersions(List, ModelBuildingRequest, ModelProblemCollector) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 705 Medium

org.apache.maven.model.building.DefaultModelBuildingRequest

Bug Category Details Line Priority
org.apache.maven.model.building.DefaultModelBuildingRequest.getBuildStartTime() may expose internal representation by returning DefaultModelBuildingRequest.buildStartTime MALICIOUS_CODE EI_EXPOSE_REP 332 Medium
org.apache.maven.model.building.DefaultModelBuildingRequest.setBuildStartTime(Date) may expose internal representation by storing an externally mutable object into DefaultModelBuildingRequest.buildStartTime MALICIOUS_CODE EI_EXPOSE_REP2 338 Medium
Inconsistent synchronization of org.apache.maven.model.building.DefaultModelBuildingRequest.modelSource; locked 75% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 133 Medium
Inconsistent synchronization of org.apache.maven.model.building.DefaultModelBuildingRequest.pomFile; locked 50% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 115 Medium

org.apache.maven.model.building.ModelBuildingException

Bug Category Details Line Priority
org.apache.maven.model.building.DefaultModelBuildingResult stored into non-transient field ModelBuildingException.result BAD_PRACTICE SE_BAD_FIELD_STORE 65 Medium

org.apache.maven.model.building.Result$2

Bug Category Details Line Priority
input must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 185 Medium

org.apache.maven.model.building.Result$3

Bug Category Details Line Priority
input must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 200 Medium

org.apache.maven.model.building.Result$4

Bug Category Details Line Priority
input must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 243 Medium

org.apache.maven.model.io.DefaultModelReader

Bug Category Details Line Priority
org.apache.maven.model.io.DefaultModelReader.read(File, Map) may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 55 Medium

org.apache.maven.model.io.DefaultModelWriter

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.model.io.DefaultModelWriter.write(File, Map, Model) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 53 Medium

org.apache.maven.model.superpom.DefaultSuperPomProvider

Bug Category Details Line Priority
org.apache.maven.model.superpom.DefaultSuperPomProvider.getSuperModel(String) may fail to clean up java.io.InputStream EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION 63 Medium