FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
Summary
| Classes | Bugs | Errors | Missing Classes |
|---|
| 163 | 37 | 0 | 0 |
org.apache.maven.index.ArtifactContext
| Bug | Category | Details | Line | Priority |
|---|
| org.apache.maven.index.ArtifactContext.getPomModel() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 96 | Medium |
org.apache.maven.index.ArtifactContext$ModelReader
| Bug | Category | Details | Line | Priority |
|---|
| Found reliance on default encoding in org.apache.maven.index.ArtifactContext$ModelReader.readPomInputStream(InputStream): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 244 | High |
org.apache.maven.index.ArtifactInfo
| Bug | Category | Details | Line | Priority |
|---|
| Class org.apache.maven.index.ArtifactInfo defines non-transient non-serializable instance field fields | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
| Class org.apache.maven.index.ArtifactInfo defines non-transient non-serializable instance field matchHighlights | BAD_PRACTICE | SE_BAD_FIELD | Not available | High |
org.apache.maven.index.ArtifactInfo$ContextVersionComparator
org.apache.maven.index.ArtifactInfo$RepositoryVersionComparator
org.apache.maven.index.ArtifactInfo$VersionComparator
| Bug | Category | Details | Line | Priority |
|---|
| org.apache.maven.index.ArtifactInfo$VersionComparator.compare(ArtifactInfo, ArtifactInfo) negates the return value of org.sonatype.aether.version.Version.compareTo(Object) | BAD_PRACTICE | RV_NEGATING_RESULT_OF_COMPARETO | 570 | Medium |
| org.apache.maven.index.ArtifactInfo$VersionComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | 553-610 | Medium |
org.apache.maven.index.DefaultIteratorResultSet
org.apache.maven.index.DefaultNexusIndexer
| Bug | Category | Details | Line | Priority |
|---|
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.DefaultNexusIndexer.scan(IndexingContext, String, ArtifactScanningListener, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 309 | Medium |
org.apache.maven.index.DefaultScanner$ScannerFileComparator
org.apache.maven.index.context.DefaultIndexingContext
| Bug | Category | Details | Line | Priority |
|---|
| org.apache.maven.index.context.DefaultIndexingContext.getTimestamp() may expose internal representation by returning DefaultIndexingContext.timestamp | MALICIOUS_CODE | EI_EXPOSE_REP | 407 | Medium |
| org.apache.maven.index.context.DefaultIndexingContext.updateTimestamp(boolean, Date) may expose internal representation by storing an externally mutable object into DefaultIndexingContext.timestamp | MALICIOUS_CODE | EI_EXPOSE_REP2 | 397 | Medium |
| org.apache.maven.index.context.DefaultIndexingContext.getAllGroups() is unsynchronized, org.apache.maven.index.context.DefaultIndexingContext.setAllGroups(Collection) is synchronized | MT_CORRECTNESS | UG_SYNC_SET_UNSYNC_GET | 736 | Medium |
| org.apache.maven.index.context.DefaultIndexingContext.getRootGroups() is unsynchronized, org.apache.maven.index.context.DefaultIndexingContext.setRootGroups(Collection) is synchronized | MT_CORRECTNESS | UG_SYNC_SET_UNSYNC_GET | 749 | Medium |
org.apache.maven.index.creator.MavenPluginArtifactInfoIndexCreator
| Bug | Category | Details | Line | Priority |
|---|
| Found reliance on default encoding in org.apache.maven.index.creator.MavenPluginArtifactInfoIndexCreator.checkMavenPlugin(ArtifactInfo, File): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 106 | High |
org.apache.maven.index.incremental.DefaultIncrementalHandler
| Bug | Category | Details | Line | Priority |
|---|
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.incremental.DefaultIncrementalHandler.cleanUpIncrementalChunks(IndexPackingRequest, Properties) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 263 | Medium |
org.apache.maven.index.locator.ArtifactLocator
| Bug | Category | Details | Line | Priority |
|---|
| org.apache.maven.index.locator.ArtifactLocator.locate(File, GavCalculator, Gav) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 59 | Medium |
org.apache.maven.index.packer.DefaultIndexPacker
| Bug | Category | Details | Line | Priority |
|---|
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.packer.DefaultIndexPacker.packIndexArchive(IndexingContext, OutputStream) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 295 | Medium |
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.index.packer.DefaultIndexPacker.packIndexArchive(IndexingContext, OutputStream) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 271 | Medium |
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.packer.DefaultIndexPacker.writeIndexArchive(IndexingContext, File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 244 | Medium |
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.packer.DefaultIndexPacker.writeIndexData(IndexingContext, List, File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 426 | Medium |
org.apache.maven.index.updater.DefaultIndexUpdater
| Bug | Category | Details | Line | Priority |
|---|
| Redundant nullcheck of localTimestamp, which is known to be non-null in org.apache.maven.index.updater.DefaultIndexUpdater.fetchAndUpdateIndex(IndexUpdateRequest, ResourceFetcher, DefaultIndexUpdater$IndexAdaptor) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 848 | Medium |
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.index.updater.DefaultIndexUpdater.fetchAndUpdateIndex(IndexUpdateRequest) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 132 | Medium |
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.updater.DefaultIndexUpdater.loadIndexDirectory(IndexUpdateRequest, ResourceFetcher, boolean, String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 182 | Medium |
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.index.updater.DefaultIndexUpdater.loadIndexDirectory(IndexUpdateRequest, ResourceFetcher, boolean, String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 183 | Medium |
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.updater.DefaultIndexUpdater.storeIndexProperties(File, String, Properties) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 452 | Medium |
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.updater.DefaultIndexUpdater.unpackIndexArchive(InputStream, Directory, IndexingContext) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 282 | Medium |
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.index.updater.DefaultIndexUpdater.unpackIndexArchive(InputStream, Directory, IndexingContext) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 266 | Medium |
org.apache.maven.index.updater.IndexDataReader$IndexDataReadResult
| Bug | Category | Details | Line | Priority |
|---|
| org.apache.maven.index.updater.IndexDataReader$IndexDataReadResult.getTimestamp() may expose internal representation by returning IndexDataReader$IndexDataReadResult.timestamp | MALICIOUS_CODE | EI_EXPOSE_REP | 293 | Medium |
| org.apache.maven.index.updater.IndexDataReader$IndexDataReadResult.setTimestamp(Date) may expose internal representation by storing an externally mutable object into IndexDataReader$IndexDataReadResult.timestamp | MALICIOUS_CODE | EI_EXPOSE_REP2 | 288 | Medium |
org.apache.maven.index.updater.IndexUpdateResult
| Bug | Category | Details | Line | Priority |
|---|
| org.apache.maven.index.updater.IndexUpdateResult.getTimestamp() may expose internal representation by returning IndexUpdateResult.timestamp | MALICIOUS_CODE | EI_EXPOSE_REP | 32 | Medium |
| org.apache.maven.index.updater.IndexUpdateResult.setTimestamp(Date) may expose internal representation by storing an externally mutable object into IndexUpdateResult.timestamp | MALICIOUS_CODE | EI_EXPOSE_REP2 | 37 | Medium |
org.apache.maven.index.updater.WagonHelper$WagonFetcher$1
| Bug | Category | Details | Line | Priority |
|---|
| new org.apache.maven.index.updater.WagonHelper$WagonFetcher$1(WagonHelper$WagonFetcher, File, File) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 203 | Medium |
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.updater.WagonHelper$WagonFetcher$1.close() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 209 | Medium |
org.apache.maven.index.util.zip.TrueZipZipFileHandle
| Bug | Category | Details | Line | Priority |
|---|
| Redundant nullcheck of entry, which is known to be non-null in org.apache.maven.index.util.zip.TrueZipZipFileHandle.getEntryContent(String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 96 | Medium |
| Redundant nullcheck of de.schlichtherle.truezip.zip.ZipFile.getEntry(String), which is known to be non-null in org.apache.maven.index.util.zip.TrueZipZipFileHandle.hasEntry(String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 54 | Medium |
