FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 169 |
32 |
0 |
0 |
org.apache.maven.index.ArtifactInfo
| Bug |
Category |
Details |
Line |
Priority |
| Class org.apache.maven.index.ArtifactInfo defines non-transient non-serializable instance field fields |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
High |
| Class org.apache.maven.index.ArtifactInfo defines non-transient non-serializable instance field matchHighlights |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
High |
org.apache.maven.index.ArtifactInfo$ContextVersionComparator
org.apache.maven.index.ArtifactInfo$RepositoryVersionComparator
org.apache.maven.index.ArtifactInfo$VersionComparator
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.index.ArtifactInfo$VersionComparator.compare(ArtifactInfo, ArtifactInfo) negates the return value of org.eclipse.aether.version.Version.compareTo(Object) |
BAD_PRACTICE |
RV_NEGATING_RESULT_OF_COMPARETO |
610 |
Medium |
| org.apache.maven.index.ArtifactInfo$VersionComparator implements Comparator but not Serializable |
BAD_PRACTICE |
SE_COMPARATOR_SHOULD_BE_SERIALIZABLE |
593-650 |
Medium |
org.apache.maven.index.DefaultIteratorResultSet
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.index.DefaultIteratorResultSet.finalize() is public; should be protected |
MALICIOUS_CODE |
FI_PUBLIC_SHOULD_BE_PROTECTED |
199-208 |
Medium |
| Useless object stored in variable matchHighlightRequests of method new org.apache.maven.index.DefaultIteratorResultSet(IteratorSearchRequest, NexusIndexMultiSearcher, List, TopDocs) |
STYLE |
UC_USELESS_OBJECT |
115 |
Medium |
org.apache.maven.index.DefaultScanner$ScannerFileComparator
org.apache.maven.index.IteratorSearchResponse$1
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.index.IteratorSearchResponse$1.next() can't throw NoSuchElementException |
BAD_PRACTICE |
IT_NO_SUCH_ELEMENT |
86 |
Medium |
org.apache.maven.index.artifact.DefaultArtifactPackagingMapper
| Bug |
Category |
Details |
Line |
Priority |
| Possible exposure of partially initialized object in org.apache.maven.index.artifact.DefaultArtifactPackagingMapper.getPackaging2extensionMapping() |
MT_CORRECTNESS |
DC_PARTIALLY_CONSTRUCTED |
98 |
Medium |
| Inconsistent synchronization of org.apache.maven.index.artifact.DefaultArtifactPackagingMapper.propertiesFile; locked 83% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
83 |
Medium |
org.apache.maven.index.context.DefaultIndexingContext
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.index.context.DefaultIndexingContext.getTimestamp() may expose internal representation by returning DefaultIndexingContext.timestamp |
MALICIOUS_CODE |
EI_EXPOSE_REP |
468 |
Medium |
| org.apache.maven.index.context.DefaultIndexingContext.updateTimestamp(boolean, Date) may expose internal representation by storing an externally mutable object into DefaultIndexingContext.timestamp |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
458 |
Medium |
| Return value of IndexCreator.getIndexerFields() ignored, but method has no side effect |
STYLE |
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT |
161 |
Medium |
| org.apache.maven.index.context.DefaultIndexingContext.getAllGroups() is unsynchronized, org.apache.maven.index.context.DefaultIndexingContext.setAllGroups(Collection) is synchronized |
MT_CORRECTNESS |
UG_SYNC_SET_UNSYNC_GET |
816 |
Medium |
| org.apache.maven.index.context.DefaultIndexingContext.getRootGroups() is unsynchronized, org.apache.maven.index.context.DefaultIndexingContext.setRootGroups(Collection) is synchronized |
MT_CORRECTNESS |
UG_SYNC_SET_UNSYNC_GET |
829 |
Medium |
org.apache.maven.index.creator.MavenPluginArtifactInfoIndexCreator
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.index.creator.MavenPluginArtifactInfoIndexCreator.checkMavenPlugin(ArtifactInfo, File): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
98 |
High |
| Exception is caught when Exception is not thrown in org.apache.maven.index.creator.MavenPluginArtifactInfoIndexCreator.checkMavenPlugin(ArtifactInfo, File) |
STYLE |
REC_CATCH_EXCEPTION |
114 |
Medium |
org.apache.maven.index.incremental.DefaultIncrementalHandler
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.apache.maven.index.incremental.DefaultIncrementalHandler.cleanUpIncrementalChunks(IndexPackingRequest, Properties) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
238 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.incremental.DefaultIncrementalHandler.cleanUpIncrementalChunks(IndexPackingRequest, Properties) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
255 |
Medium |
org.apache.maven.index.packer.DefaultIndexPacker
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.packer.DefaultIndexPacker.writeIndexData(IndexPackingRequest, List, File) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
210 |
Medium |
org.apache.maven.index.updater.DefaultIndexUpdater
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of localTimestamp, which is known to be non-null in org.apache.maven.index.updater.DefaultIndexUpdater.fetchAndUpdateIndex(IndexUpdateRequest, ResourceFetcher, DefaultIndexUpdater$IndexAdaptor) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
724 |
Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.index.updater.DefaultIndexUpdater.fetchAndUpdateIndex(IndexUpdateRequest) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
136 |
Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.index.updater.DefaultIndexUpdater.loadIndexDirectory(IndexUpdateRequest, ResourceFetcher, boolean, String) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
194 |
Medium |
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.updater.DefaultIndexUpdater.storeIndexProperties(File, String, Properties) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
344 |
Medium |
org.apache.maven.index.updater.IndexDataReader$IndexDataReadResult
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.index.updater.IndexDataReader$IndexDataReadResult.getTimestamp() may expose internal representation by returning IndexDataReader$IndexDataReadResult.timestamp |
MALICIOUS_CODE |
EI_EXPOSE_REP |
325 |
Medium |
| org.apache.maven.index.updater.IndexDataReader$IndexDataReadResult.setTimestamp(Date) may expose internal representation by storing an externally mutable object into IndexDataReader$IndexDataReadResult.timestamp |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
320 |
Medium |
org.apache.maven.index.updater.IndexUpdateResult
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.index.updater.IndexUpdateResult.getTimestamp() may expose internal representation by returning IndexUpdateResult.timestamp |
MALICIOUS_CODE |
EI_EXPOSE_REP |
41 |
Medium |
| org.apache.maven.index.updater.IndexUpdateResult.setTimestamp(Date) may expose internal representation by storing an externally mutable object into IndexUpdateResult.timestamp |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
46 |
Medium |
org.apache.maven.index.updater.WagonHelper$WagonFetcher
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.updater.WagonHelper$WagonFetcher.retrieve(String, File) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
216 |
Medium |
org.apache.maven.index.updater.WagonHelper$WagonFetcher$1
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.index.updater.WagonHelper$WagonFetcher$1.close() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
202 |
Medium |
