Tag List Report
The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.
| Tag Class | Total number of occurrences | Tag strings used by tag class |
|---|---|---|
| Deprecated Work | 55 | @deprecated |
| FIXME Work | 1 | fixme, @fixme |
| Todo Work | 121 | todo, @todo |
Each tag is detailed below:
Deprecated Work
Number of occurrences found in the code: 55
| org.apache.maven.ArtifactFilterManager | Line |
|---|---|
| use {@code META-INF/maven/extension.xml} to define artifacts exported by Maven core and plugin extensions. | 32 |
| use {@code META-INF/maven/extension.xml} to define artifacts exported by Maven core and plugin extensions. | 48 |
| org.apache.maven.ArtifactFilterManagerDelegate | Line |
| use {@code META-INF/maven/extension.xml} to define artifacts exported by Maven core extensions. | 24 |
| org.apache.maven.DefaultProjectDependenciesResolver | Line |
| As of 3.2.2, and there is no direct replacement. This is an internal class which was not marked as such, but should have been. | 45 |
| org.apache.maven.ProjectDependenciesResolver | Line |
| As of 3.2.2, and there is no direct replacement. This is an internal class which was not marked as such, but should have been. | 30 |
| org.apache.maven.artifact.handler.DefaultArtifactHandler | Line |
| This ctor is present only for Plexus XML defined component compatibility, do not use it. | 48 |
| org.apache.maven.artifact.metadata.ArtifactMetadataRetrievalException | Line |
| use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} | 32 |
| use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} | 41 |
| use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} | 51 |
| org.apache.maven.classrealm.ClassRealmRequest | Line |
| Use {@link #getParentImports()} instead. | 71 |
| org.apache.maven.execution.DefaultMavenExecutionRequest | Line |
| use {@link #setPom(File)} | 573 |
| org.apache.maven.execution.MavenExecutionRequest | Line |
| Since Maven 4: use {@link #getProjectActivation()}. | 151 |
| Since Maven 4: use {@link #getProjectActivation()}. | 157 |
| Since Maven 4: use {@link #getProjectActivation()}. | 166 |
| Since Maven 4: use {@link #getProjectActivation()}. | 174 |
| Since Maven 4: use {@link #getProfileActivation()}. | 286 |
| Since Maven 4: use {@link #getProfileActivation()}. | 292 |
| Since Maven 4: use {@link #getProfileActivation()}. | 298 |
| Since Maven 4: use {@link #getProfileActivation()}. | 305 |
| Since Maven 4: use {@link #getProfileActivation()}. | 311 |
| Since Maven 4: use {@link #getProfileActivation()}. | 317 |
| Since Maven 4: use {@link #getProfileActivation()}. | 323 |
| Since Maven 4: use {@link #getProfileActivation()}. | 330 |
| org.apache.maven.execution.MavenSession | Line |
| This appears not to be used anywhere within Maven itself. | 270 |
| Use either {@link #getUserProperties()} or {@link #getSystemProperties()}. | 407 |
| org.apache.maven.execution.ProfileActivation | Line |
| Use {@link #getRequiredActiveProfileIds()} and {@link #getOptionalActiveProfileIds()} instead. | 40 |
| Use {@link #getRequiredInactiveProfileIds()} and {@link #getOptionalInactiveProfileIds()} instead. | 49 |
| Use {@link #activateOptionalProfile(String)} or {@link #activateRequiredProfile(String)} instead. | 59 |
| Use {@link #deactivateOptionalProfile(String)} or {@link #deactivateRequiredProfile(String)} instead. | 70 |
| org.apache.maven.execution.ProjectActivation | Line |
| Use {@link #getRequiredActiveProjectSelectors()} and {@link #getOptionalActiveProjectSelectors()} instead. | 107 |
| Use {@link #getRequiredInactiveProjectSelectors()} and {@link #getOptionalInactiveProjectSelectors()} instead. | 117 |
| Use {@link #activateOptionalProject(String)} or {@link #activateRequiredProject(String)} instead. | 128 |
| Use {@link #deactivateOptionalProject(String)} or {@link #deactivateRequiredProject(String)} instead. | 140 |
| org.apache.maven.lifecycle.internal.stub.LifecycleExecutionPlanCalculatorStub | Line |
| instead use {@link #getNumberOfExecutions(ProjectBuildList)} | 100 |
| org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping | Line |
| use lifecycles instead | 38 |
| Should not be used in Java code. | 45 |
| org.apache.maven.plugin.CacheUtils | Line |
| Use {@link Objects#equals(Object)} | 34 |
| Use {@link Objects#hashCode(Object)} | 42 |
| org.apache.maven.project.DefaultProjectBuildingRequest | Line |
| This got added when implementing MNG-2199 and is no longer used. Commit 6cf9320942c34bc68205425ab696b1712ace9ba4 updated the way 'MavenProject' objects are initialized. | 195 |
| This got added when implementing MNG-2199 and is no longer used. Commit 6cf9320942c34bc68205425ab696b1712ace9ba4 updated the way 'MavenProject' objects are initialized. | 206 |
| org.apache.maven.project.DuplicateProjectException | Line |
| use {@link #DuplicateProjectException(String, File, File, String)} | 36 |
| use {@link #DuplicateProjectException(String, File, File, String)} | 43 |
| org.apache.maven.project.MavenProject | Line |
| Please use {@link MavenProjectHelper} | 787 |
| Use MavenProjectHelper.attachArtifact(..) instead. | 1628 |
| Use {@link org.apache.maven.model.io.ModelWriter}. | 1634 |
| Use {@link org.apache.maven.model.io.ModelWriter}. | 1643 |
| org.apache.maven.project.ProjectBuildingException | Line |
| use {@link #getPomFile()} | 73 |
| org.apache.maven.project.ProjectBuildingRequest | Line |
| This got added when implementing MNG-2199 and is no longer used. Commit 6cf9320942c34bc68205425ab696b1712ace9ba4 updated the way 'MavenProject' objects are initialized. | 173 |
| This got added when implementing MNG-2199 and is no longer used. Commit 6cf9320942c34bc68205425ab696b1712ace9ba4 updated the way 'MavenProject' objects are initialized. | 181 |
| org.apache.maven.repository.DelegatingLocalArtifactRepository | Line |
| instead use {@link #getIdeWorkspace()} | 58 |
| org.apache.maven.repository.legacy.metadata.ArtifactMetadataRetrievalException | Line |
| use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} | 33 |
| use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} | 42 |
| use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} | 52 |
| org.apache.maven.toolchain.DefaultToolchainsBuilder | Line |
| instead use {@link org.apache.maven.toolchain.building.DefaultToolchainsBuilder} | 33 |
| org.apache.maven.toolchain.java.DefaultJavaToolChain | Line |
| clients that do not require compatibility with Maven 3.2.3 and earlier should link to {@link JavaToolchainImpl} instead. | 29 |
FIXME Work
Number of occurrences found in the code: 1
| org.apache.maven.project.MavenProject | Line |
|---|---|
| This is hacky. What if module directory doesn't match artifactid, and parent is coming from the repository?? | 1262 |
Todo Work
Number of occurrences found in the code: 121
| org.apache.maven.AbstractMavenLifecycleParticipant | Line |
|---|---|
| This is too early for build extensions, so maybe just remove it? | 58 |
| org.apache.maven.DefaultMaven | Line |
| Hack to make the cycle detection the same for the new graph builder | 155 |
| org.apache.maven.artifact.DependencyResolutionRequiredException | Line |
| it may be better for artifact.getFile() to throw it - perhaps it is a runtime exception? | 25 |
| org.apache.maven.artifact.repository.MavenArtifactRepository | Line |
| completely separate local and remote artifact repositories | 34 |
| need to URL decode for spaces? | 225 |
| org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata | Line |
| not sure that it should assume this, maybe the calls to addMetadata should pre-merge, then artifact replaces? | 150 |
| not sure that it should assume this, maybe the calls to addMetadata should pre-merge, then artifact replaces? | 157 |
| org.apache.maven.artifact.repository.metadata.RepositoryMetadata | Line |
| not happy about the store method - they use "this" | 28 |
| org.apache.maven.artifact.resolver.ArtifactResolutionResult | Line |
| carlos: all these possible has*Exceptions and get*Exceptions methods make the clients too complex requiring a long list of checks, need to create a parent/interface/encapsulation for the types of exceptions | 42 |
| this needs to accept a {@link OverConstrainedVersionException} as returned by {@link #getVersionRangeViolation(int)} but it's not used like that in DefaultLegacyArtifactCollector | 162 |
| org.apache.maven.artifact.resolver.ResolutionListener | Line |
| Use the following two instead of manageArtifact | 80 |
| Remove ResolutionListenerDM interface | 81 |
| org.apache.maven.artifact.resolver.ResolutionNode | Line |
| if it was null, we really need to go find them now... or is this taken care of by the ordering? | 176 |
| org.apache.maven.artifact.resolver.filter.ExcludesArtifactFilter | Line |
| I think this is equiv. to exclusion set filter in maven-core | 28 |
| org.apache.maven.artifact.resolver.filter.IncludesArtifactFilter | Line |
| what about wildcards? Just specifying groups? versions? | 45 |
| org.apache.maven.execution.BuildSummary | Line |
| Validate for < 0? | 49 |
| org.apache.maven.execution.DefaultMavenExecutionRequest | Line |
| this does not belong here. | 915 |
| org.apache.maven.internal.impl.AbstractSession | Line |
| --No comment-- | 121 |
| --No comment-- | 130 |
| org.apache.maven.internal.impl.DefaultNode | Line |
| --No comment-- | 68 |
| org.apache.maven.internal.impl.DefaultProjectManager | Line |
| apiv4 | 67 |
| apiv4 | 116 |
| apiv4 | 144 |
| org.apache.maven.internal.impl.DefaultSession | Line |
| --No comment-- | 280 |
| org.apache.maven.internal.impl.DefaultTransport | Line |
| check file size and prevent OOM? | 79 |
| org.apache.maven.internal.impl.TestRepositorySystem | Line |
| Auto-generated method stub | 189 |
| Auto-generated method stub | 287 |
| org.apache.maven.lifecycle.DefaultLifecycleExecutor | Line |
| This whole method could probably removed by injecting lifeCyclePluginAnalyzer straight into client site. | 99 |
| But for some reason the whole plexus appcontext refuses to start when I try this. | 100 |
| org.apache.maven.lifecycle.DefaultLifecycles | Line |
| The configuration for the lifecycle needs to be externalized so that I can use the annotations properly for the wiring and reference and external source for the lifecycle configuration. | 41 |
| Remove the following code when maven-compat is gone This code is here to ensure maven-compat's EmptyLifecycleExecutor keeps on working. | 132 |
| org.apache.maven.lifecycle.MavenExecutionPlan | Line |
| lifecycles being executed | 35 |
| what runs in each phase | 36 |
| plugins that need downloading | 37 |
| project dependencies that need downloading | 38 |
| unfortunately the plugins need to be downloaded in order to get the plugin.xml file. need to externalize this from the plugin archive. | 39 |
| this will be the class that people get in IDEs to modify | 41 |
| org.apache.maven.lifecycle.internal.DefaultLifecycleExecutionPlanCalculator | Line |
| take repo mans into account as one may be aggregating prefixes of many | 521 |
| collect at the root of the repository, read the one at the root, and fetch remote if something is missing or the user forces the issue | 522 |
| org.apache.maven.lifecycle.internal.DependencyContext | Line |
| From a concurrency perspective, this class is not good. The combination of mutable/immutable state is not nice | 37 |
| org.apache.maven.lifecycle.internal.MojoDescriptorCreator | Line |
| take repo mans into account as one may be aggregating prefixes of many | 224 |
| collect at the root of the repository, read the one at the root, and fetch remote if something is missing or the user forces the issue | 225 |
| org.apache.maven.lifecycle.internal.MojoExecutor | Line |
| ideally, the builder should take care of the ordering in a smarter way | 218 |
| and concurrency issues fixed with MNG-7157 | 219 |
| when resolver 1.7.3 is released, the code below should be changed to | 275 |
| Map<MavenProject, Lock> locks = ( Map ) ((Map) data).computeIfAbsent( | 276 |
| ProjectLock.class, l -> new ConcurrentHashMap<>() ); | 277 |
| org.apache.maven.lifecycle.internal.ProjectBuildList | Line |
| Optimize; or maybe just rewrite the whole way aggregating mojos are being run. | 50 |
| org.apache.maven.lifecycle.internal.ProjectBuildListTest | Line |
| Make multiple segments on projectBuildList | 45 |
| org.apache.maven.lifecycle.internal.ProjectIndex | Line |
| Kristian wonders if this class really is necessary and if it overlaps other concepts. | 37 |
| org.apache.maven.lifecycle.internal.TaskSegment | Line |
| Consider throwing UnsupportedSomething on hashCode/equals | 65 |
| org.apache.maven.lifecycle.internal.builder.BuilderCommon | Line |
| I'm really wondering where this method belongs; smells like it should be on MavenProject, but for some reason it isn't ? This localization is kind-of a code smell. | 224 |
| org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder | Line |
| MNG-5766 changes likely made this redundant | 175 |
| org.apache.maven.lifecycle.providers.packaging.AbstractLifecycleMappingProvider | Line |
| Update!!! | 55 |
| org.apache.maven.plugin.DefaultBuildPluginManager | Line |
| the antrun plugin has its own configurator, the only plugin that does. might need to think about how that works | 46 |
| remove the coreArtifactFilterManager | 47 |
| pluginDescriptor classRealm and artifacts are set as a side effect of this call, which is not nice. | 195 |
| org.apache.maven.plugin.PluginManagerTest | Line |
| These two tests display a lack of symmetry with respect to the input which is a free form string and the mojo descriptor which comes back. All the free form parsing needs to be done somewhere else, this is really the function of the CLI, and then the pre-processing of that output still needs to be fed into a hinting process which helps flesh out the full specification of the plugin. The plugin manager should only deal in concrete terms -- all version finding mumbo jumbo is a customization to base functionality the plugin manager provides. | 90 |
| turn an equivalent back on when the RR plugin is released. | 99 |
| this will be the basis of the customizable lifecycle execution so need to figure this out quickly. | 124 |
| org.apache.maven.plugin.PluginParameterExpressionEvaluator | Line |
| don't catch exception | 187 |
| don't catch exception | 209 |
| don't catch exception | 229 |
| don't catch exception | 266 |
| without #, this could just be an evaluate call... | 310 |
| Copied from the DefaultInterpolator. We likely want to resurrect the PathTranslator or at least a similar component for re-usage | 346 |
| org.apache.maven.plugin.PluginParameterExpressionEvaluatorTest | Line |
| Auto-generated method stub | 410 |
| org.apache.maven.plugin.PluginParameterExpressionEvaluatorV4 | Line |
| v4 | 173 |
| v4 | 178 |
| don't catch exception | 190 |
| v4 | 205 |
| don't catch exception | 217 |
| v4 | 222 |
| v4 | 226 |
| don't catch exception | 238 |
| v4 | 243 |
| v4 | 246 |
| don't catch exception | 278 |
| without #, this could just be an evaluate call... | 322 |
| Copied from the DefaultInterpolator. We likely want to resurrect the PathTranslator or at least a similar component for re-usage | 358 |
| org.apache.maven.plugin.internal.DefaultMavenPluginManager | Line |
| could the configuration be passed to lookup and the configurator known to plexus via the descriptor so that this method could entirely be handled by a plexus lookup? | 612 |
| store plugin version | 769 |
| figure out how to use the same PluginDescriptor when running mojos | 800 |
| org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver | Line |
| We currently cannot tell which <dependencyManagement> section contained the management information. When the resolver provides this information, these log messages should be updated to contain it. | 242 |
| org.apache.maven.project.DefaultProjectBuildingHelper | Line |
| not used? Then remove | 67 |
| org.apache.maven.project.DefaultProjectDependenciesResolver | Line |
| We currently cannot tell which <dependencyManagement> section contained the management information. When the resolver provides this information, these log messages should be updated to contain it. | 234 |
| org.apache.maven.project.DuplicateArtifactAttachmentException | Line |
| Make this a checked exception, and modify the API of MavenProjectHelper. Currently, this modification would create compatibility problems for existing plugins. | 29 |
| org.apache.maven.project.MavenProject | Line |
| I would like to get rid of this. jvz. | 222 |
| let the scope handler deal with this | 328 |
| this checking for file == null happens because the resolver has been confused about the root artifact or not. things like the stupid dummy artifact coming from surefire. | 340 |
| let the scope handler deal with this | 374 |
| this should not be allowed to be null. | 425 |
| classpath check doesn't belong here - that's the other method | 1341 |
| let the scope handler deal with this | 1343 |
| let the scope handler deal with this | 1365 |
| classpath check doesn't belong here - that's the other method | 1389 |
| let the scope handler deal with this | 1433 |
| classpath check doesn't belong here - that's the other method | 1455 |
| let the scope handler deal with this | 1457 |
| let the scope handler deal with this | 1476 |
| classpath check doesn't belong here - that's the other method | 1490 |
| let the scope handler deal with this | 1492 |
| let the scope handler deal with this | 1512 |
| org.apache.maven.project.ProjectBuilderTest | Line |
| a similar test should be created to test the dependency management (basically all usages of DefaultModelBuilder.getCache() are affected by MNG-6530 | 164 |
| org.apache.maven.project.ProjectSorter | Line |
| !![jc; 28-jul-2005] check this; if we're using '-r' and there are aggregator tasks, this will result in weirdness. | 250 |
| org.apache.maven.project.artifact.ActiveProjectArtifact | Line |
| I think this exposes a design flaw in that the immutable and mutable parts of an artifact are in one class and should be split. ie scope, file, etc depend on the context of use, whereas everything else is immutable. | 39 |
| org.apache.maven.project.artifact.MavenMetadataSource | Line |
| hack: don't rebuild model if it was already loaded during reactor resolution | 175 |
| shouldn't the versions be merged across relocations? | 585 |
| org.apache.maven.project.artifact.PluginArtifact | Line |
| this is duplicate of MavenPluginArtifactHandlerProvider provided one | 57 |
| org.apache.maven.project.artifact.ProjectArtifact | Line |
| this is duplicate of PomArtifactHandlerProvider provided one | 62 |
| org.apache.maven.repository.TestRepositoryConnector | Line |
| Auto-generated method stub | 128 |
| org.apache.maven.repository.TestRepositorySystem | Line |
| Auto-generated method stub | 186 |
| Auto-generated method stub | 286 |
| org.apache.maven.settings.DefaultMavenSettingsBuilder | Line |
| This replacing shouldn't be necessary as user.home should be in the context of the container and thus the value would be interpolated by Plexus | 113 |
| org.apache.maven.settings.SettingsUtilsTest | Line |
| deep compare the lists | 149 |
| deep compare the lists | 152 |
| org.apache.maven.toolchain.DefaultToolchainManager | Line |
| this class is extended, needs refactoring | 44 |
| why is this using the context | 123 |
| org.apache.maven.toolchain.DefaultToolchainManagerPrivate | Line |
| refactor this, component extending component is bad practice. | 32 |
| org.apache.maven.toolchain.RequirementMatcherFactory | Line |
| error reporting | 76 |
| org.apache.maven.toolchain.ToolchainFactory | Line |
| keep around?? */ | 38 |