FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 2.0.3

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
29 11 0 0

Files

Class Bugs
org.apache.maven.scm.provider.starteam.StarteamScmProvider 2
org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogCommand 2
org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer 2
org.apache.maven.scm.provider.starteam.command.diff.StarteamDiffConsumer 1
org.apache.maven.scm.providers.starteam.settings.io.xpp3.StarteamXpp3Reader 4

org.apache.maven.scm.provider.starteam.StarteamScmProvider

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.apache.maven.scm.provider.starteam.StarteamScmProvider.makeProviderScmRepository(String, char) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 117 High
org.apache.maven.scm.provider.starteam.StarteamScmProvider.makeProviderScmRepository(String, char) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead PERFORMANCE DM_NUMBER_CTOR 140 Medium

org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogCommand

Bug Category Details Line Priority
Load of known null value in org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogCommand.executeChangeLogCommand(ScmProviderRepository, ScmFileSet, Date, Date, ScmBranch, String) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 58 Medium
Redundant nullcheck of branch which is known to be null in org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogCommand.executeChangeLogCommand(ScmProviderRepository, ScmFileSet, Date, Date, ScmBranch, String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE 58 Medium

org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer

Bug Category Details Line Priority
new org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer(File, ScmLogger, Date, Date, String) may expose internal representation by storing an externally mutable object into StarteamChangeLogConsumer.endDate MALICIOUS_CODE EI_EXPOSE_REP2 151 Medium
new org.apache.maven.scm.provider.starteam.command.changelog.StarteamChangeLogConsumer(File, ScmLogger, Date, Date, String) may expose internal representation by storing an externally mutable object into StarteamChangeLogConsumer.startDate MALICIOUS_CODE EI_EXPOSE_REP2 149 Medium

org.apache.maven.scm.provider.starteam.command.diff.StarteamDiffConsumer

Bug Category Details Line Priority
Unread field: org.apache.maven.scm.provider.starteam.command.diff.StarteamDiffConsumer.currentDir PERFORMANCE URF_UNREAD_FIELD 56 Medium

org.apache.maven.scm.providers.starteam.settings.io.xpp3.StarteamXpp3Reader

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.apache.maven.scm.providers.starteam.settings.io.xpp3.StarteamXpp3Reader.getIntegerValue(String, String, XmlPullParser, boolean) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 364 High
Boxing/unboxing to parse a primitive org.apache.maven.scm.providers.starteam.settings.io.xpp3.StarteamXpp3Reader.getLongValue(String, String, XmlPullParser, boolean) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 394 High
Private method org.apache.maven.scm.providers.starteam.settings.io.xpp3.StarteamXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 149 Medium
Private method org.apache.maven.scm.providers.starteam.settings.io.xpp3.StarteamXpp3Reader.getDateValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 237 Medium