FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is min
Files
org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.executeClirr() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 688 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugins.javadoc.AbstractFixJavadocMojo.processFix(JavaClass) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1102 | Medium |
org.apache.maven.plugins.javadoc.AbstractJavadocMojo
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| instanceof will always return true for all non-null values in org.apache.maven.plugins.javadoc.AbstractJavadocMojo.verifyRemovedParameter(String), since all org.codehaus.plexus.util.xml.Xpp3Dom are instances of org.codehaus.plexus.util.xml.Xpp3Dom | STYLE | BC_VACUOUS_INSTANCEOF | 1920 | Medium |
| instanceof will always return true for all non-null values in org.apache.maven.plugins.javadoc.AbstractJavadocMojo.verifyReplacedParameter(String, String), since all org.codehaus.plexus.util.xml.Xpp3Dom are instances of org.codehaus.plexus.util.xml.Xpp3Dom | STYLE | BC_VACUOUS_INSTANCEOF | 1935 | Medium |
| org.apache.maven.plugins.javadoc.AbstractJavadocMojo.DEFAULT_JAVA_API_LINKS is a mutable collection which should be package protected | MALICIOUS_CODE | MS_MUTABLE_COLLECTION_PKGPROTECT | 205 | Medium |
| Redundant nullcheck of org.apache.maven.plugins.javadoc.AbstractJavadocMojo.dependencyJavadocBundles, which is known to be non-null in org.apache.maven.plugins.javadoc.AbstractJavadocMojo.resolveDependencyBundles() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 4238 | Medium |
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport(Locale) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 2153 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugins.javadoc.AbstractJavadocMojo.executeReport(Locale) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 2025 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getDependencySourcePaths() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 2353 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getJavadocOptionsFile() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 6111 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugins.javadoc.AbstractJavadocMojo.getModulesLinks() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 5624 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugins.javadoc.AbstractJavadocMojo.writeDebugJavadocScript(String, File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 5964 | Medium |
| Usage of GetResource in org.apache.maven.plugins.javadoc.AbstractJavadocMojo.fixFrameInjectionBug(File, String) may be unsafe if class is extended | BAD_PRACTICE | UI_INHERITANCE_UNSAFE_GETRESOURCE | 5350 | Medium |
org.apache.maven.plugins.javadoc.JavadocJar
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.plugins.javadoc.JavadocJar.generateArchive(File, String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 265 | Medium |
org.apache.maven.plugins.javadoc.JavadocUtil
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.apache.maven.plugins.javadoc.JavadocUtil.isValidPackageList(URL, Settings, boolean): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 1698 | High |
| org.apache.maven.plugins.javadoc.JavadocUtil.getTagletClassNames(File) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block | MALICIOUS_CODE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 775 | Medium |
| Null passed for non-null parameter of new java.io.File(String) in org.apache.maven.plugins.javadoc.JavadocUtil.getMavenHome(Log) | CORRECTNESS | NP_NULL_PARAM_DEREF | 1224 | Medium |
| Exceptional return value of java.io.File.delete() ignored in org.apache.maven.plugins.javadoc.JavadocUtil.copyJavadocResources(File, File, String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 330 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugins.javadoc.JavadocUtil.copyResource(URL, File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 830 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugins.javadoc.JavadocUtil.invoke(Log, Invoker, InvocationRequest, File, List, Properties, String) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1140 | Medium |
| org.apache.maven.plugins.javadoc.JavadocUtil.quotedPathArgument(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 267 | Medium |
org.apache.maven.plugins.javadoc.JavadocVersion
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugins.javadoc.JavadocVersion defines compareTo(JavadocVersion) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 63-81 | Medium |
org.apache.maven.plugins.javadoc.options.io.xpp3.JavadocOptionsXpp3Reader
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Boxing/unboxing to parse a primitive org.apache.maven.plugins.javadoc.options.io.xpp3.JavadocOptionsXpp3Reader.getIntegerValue(String, String, XmlPullParser, boolean) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 399 | High |
| Boxing/unboxing to parse a primitive org.apache.maven.plugins.javadoc.options.io.xpp3.JavadocOptionsXpp3Reader.getLongValue(String, String, XmlPullParser, boolean) | PERFORMANCE | DM_BOXED_PRIMITIVE_FOR_PARSING | 429 | High |
| Private method org.apache.maven.plugins.javadoc.options.io.xpp3.JavadocOptionsXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 184 | Medium |
| Private method org.apache.maven.plugins.javadoc.options.io.xpp3.JavadocOptionsXpp3Reader.getDateValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 272 | Medium |
org.apache.maven.plugins.javadoc.options.io.xpp3.JavadocOptionsXpp3Writer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.apache.maven.plugins.javadoc.options.io.xpp3.JavadocOptionsXpp3Writer.fileComment | PERFORMANCE | URF_UNREAD_FIELD | 49 | Medium |
org.apache.maven.plugins.javadoc.resolver.ResourceResolver
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugins.javadoc.resolver.ResourceResolver.resolveAndUnpack(List, SourceResolverConfig, List, boolean) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 423 | Medium |