Tag List Report

The following document contains the listing of user tags found in the code. Below is the summary of the occurrences per tag.

Tag Class Total number of occurrences Tag strings used by tag class
Deprecated Work 33 @deprecated
FIXME Work 1 fixme, @fixme
Todo Work 88 todo, @todo

Each tag is detailed below:

Deprecated Work

Number of occurrences found in the code: 33

org.apache.maven.ArtifactFilterManager Line
use {@code META-INF/maven/extension.xml} to define artifacts exported by Maven core and plugin extensions. 34
use {@code META-INF/maven/extension.xml} to define artifacts exported by Maven core and plugin extensions. 47
org.apache.maven.ArtifactFilterManagerDelegate Line
use {@code META-INF/maven/extension.xml} to define artifacts exported by Maven core extensions. 25
org.apache.maven.DefaultProjectDependenciesResolver Line
As of 3.2.2, and there is no direct replacement. This is an internal class which was not marked as such, but should have been. 46
org.apache.maven.ProjectDependenciesResolver Line
As of 3.2.2, and there is no direct replacement. This is an internal class which was not marked as such, but should have been. 32
org.apache.maven.artifact.metadata.ArtifactMetadataRetrievalException Line
use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} 32
use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} 39
use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} 46
org.apache.maven.classrealm.ClassRealmRequest Line
Use {@link #getParentImports()} instead. 74
org.apache.maven.execution.DefaultMavenExecutionRequest Line
use {@link #setPom(File)} 673
org.apache.maven.execution.MavenSession Line
This appears to only be used in the ReactorReader and we can do any processing required there 300
Use either {@link #getUserProperties()} or {@link #getSystemProperties()}. 392
org.apache.maven.lifecycle.internal.stub.LifecycleExecutionPlanCalculatorStub Line
instead use {@link #getNumberOfExecutions(ProjectBuildList)} 91
org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping Line
use lifecycles instead 37
org.apache.maven.plugin.CacheUtils Line
Use {@link Objects#equals(Object)} 37
Use {@link Objects#hashCode(Object)} 46
org.apache.maven.project.DefaultProjectBuildingRequest Line
This got added when implementing MNG-2199 and is no longer used. Commit 6cf9320942c34bc68205425ab696b1712ace9ba4 updated the way 'MavenProject' objects are initialized. 229
This got added when implementing MNG-2199 and is no longer used. Commit 6cf9320942c34bc68205425ab696b1712ace9ba4 updated the way 'MavenProject' objects are initialized. 241
org.apache.maven.project.DuplicateProjectException Line
use {@link #DuplicateProjectException(String, File, File, String)} 39
use {@link #DuplicateProjectException(String, File, File, String)} 47
org.apache.maven.project.MavenProject Line
Please use {@link MavenProjectHelper} 927
Use MavenProjectHelper.attachArtifact(..) instead. 1931
Use {@link org.apache.maven.model.io.ModelWriter}. 1939
Use {@link org.apache.maven.model.io.ModelWriter}. 1950
org.apache.maven.project.ProjectBuildingException Line
use {@link #getPomFile()} 86
org.apache.maven.project.ProjectBuildingRequest Line
This got added when implementing MNG-2199 and is no longer used. Commit 6cf9320942c34bc68205425ab696b1712ace9ba4 updated the way 'MavenProject' objects are initialized. 176
This got added when implementing MNG-2199 and is no longer used. Commit 6cf9320942c34bc68205425ab696b1712ace9ba4 updated the way 'MavenProject' objects are initialized. 184
org.apache.maven.repository.DelegatingLocalArtifactRepository Line
instead use {@link #getIdeWorkspace()} 65
org.apache.maven.repository.legacy.metadata.ArtifactMetadataRetrievalException Line
use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} 34
use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} 41
use {@link #ArtifactMetadataRetrievalException(String, Throwable, Artifact)} 48
org.apache.maven.toolchain.DefaultToolchainsBuilder Line
instead use {@link org.apache.maven.toolchain.building.DefaultToolchainsBuilder} 34
org.apache.maven.toolchain.java.DefaultJavaToolChain Line
clients that do not require compatibility with Maven 3.2.3 and earlier should link to {@link JavaToolchainImpl} instead. 30

FIXME Work

Number of occurrences found in the code: 1

org.apache.maven.project.MavenProject Line
This is hacky. What if module directory doesn't match artifactid, and parent is coming from the repository?? 1500

Todo Work

Number of occurrences found in the code: 88

org.apache.maven.AbstractMavenLifecycleParticipant Line
This is too early for build extensions, so maybe just remove it? 56
org.apache.maven.DefaultMaven Line
Hack to make the cycle detection the same for the new graph builder 113
org.apache.maven.artifact.DependencyResolutionRequiredException Line
it may be better for artifact.getFile() to throw it - perhaps it is a runtime exception? 26
org.apache.maven.artifact.repository.MavenArtifactRepository Line
completely separate local and remote artifact repositories 36
need to URL decode for spaces? 246
org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata Line
not sure that it should assume this, maybe the calls to addMetadata should pre-merge, then artifact replaces? 183
not sure that it should assume this, maybe the calls to addMetadata should pre-merge, then artifact replaces? 191
org.apache.maven.artifact.repository.metadata.RepositoryMetadata Line
not happy about the store method - they use "this" 29
org.apache.maven.artifact.resolver.ArtifactResolutionResult Line
carlos: all these possible has*Exceptions and get*Exceptions methods make the clients too complex requiring a long list of checks, need to create a parent/interface/encapsulation for the types of exceptions 44
this needs to accept a {@link OverConstrainedVersionException} as returned by {@link #getVersionRangeViolation(int)} but it's not used like that in DefaultLegacyArtifactCollector 187
org.apache.maven.artifact.resolver.ResolutionListener Line
Use the following two instead of manageArtifact 85
Remove ResolutionListenerDM interface 86
org.apache.maven.artifact.resolver.ResolutionNode Line
if it was null, we really need to go find them now... or is this taken care of by the ordering? 205
org.apache.maven.artifact.resolver.filter.ExcludesArtifactFilter Line
I think this is equiv. to exclusion set filter in maven-core 30
org.apache.maven.artifact.resolver.filter.IncludesArtifactFilter Line
what about wildcards? Just specifying groups? versions? 52
org.apache.maven.execution.BuildSummary Line
Validate for < 0? 53
org.apache.maven.execution.DefaultMavenExecutionRequest Line
this does not belong here. 1089
org.apache.maven.lifecycle.DefaultLifecycleExecutor Line
This whole method could probably removed by injecting lifeCyclePluginAnalyzer straight into client site. 100
But for some reason the whole plexus appcontext refuses to start when I try this. 101
org.apache.maven.lifecycle.DefaultLifecycles Line
The configuration for the lifecycle needs to be externalized so that I can use the annotations properly for the wiring and reference and external source for the lifecycle configuration. 41
org.apache.maven.lifecycle.MavenExecutionPlan Line
lifecycles being executed 37
what runs in each phase 38
plugins that need downloading 39
project dependencies that need downloading 40
unfortunately the plugins need to be downloaded in order to get the plugin.xml file. need to externalize this from the plugin archive. 41
this will be the class that people get in IDEs to modify 43
org.apache.maven.lifecycle.internal.DefaultLifecycleExecutionPlanCalculator Line
take repo mans into account as one may be aggregating prefixes of many 527
collect at the root of the repository, read the one at the root, and fetch remote if something is missing or the user forces the issue 528
org.apache.maven.lifecycle.internal.DependencyContext Line
From a concurrency perspective, this class is not good. The combination of mutable/immutable state is not nice 39
org.apache.maven.lifecycle.internal.MojoDescriptorCreator Line
take repo mans into account as one may be aggregating prefixes of many 243
collect at the root of the repository, read the one at the root, and fetch remote if something is missing or the user forces the issue 244
org.apache.maven.lifecycle.internal.ProjectBuildList Line
Optimize; or maybe just rewrite the whole way aggregating mojos are being run. 55
org.apache.maven.lifecycle.internal.ProjectBuildListTest Line
Make multiple segments on projectBuildList 44
org.apache.maven.lifecycle.internal.ProjectIndex Line
Kristian wonders if this class really is necessary and if it overlaps other concepts. 39
org.apache.maven.lifecycle.internal.TaskSegment Line
Consider throwing UnsupportedSomething on hashCode/equals 72
org.apache.maven.lifecycle.internal.builder.BuilderCommon Line
I'm really wondering where this method belongs; smells like it should be on MavenProject, but for some reason it isn't ? This localization is kind-of a code smell. 191
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder Line
MNG-5766 changes likely made this redundant 173
org.apache.maven.plugin.DefaultBuildPluginManager Line
the antrun plugin has its own configurator, the only plugin that does. might need to think about how that works 40
remove the coreArtifactFilterManager 41
pluginDescriptor classRealm and artifacts are set as a side effect of this call, which is not nice. 221
org.apache.maven.plugin.PluginManagerTest Line
These two tests display a lack of symmetry with respect to the input which is a free form string and the mojo descriptor which comes back. All the free form parsing needs to be done somewhere else, this is really the function of the CLI, and then the pre-processing of that output still needs to be fed into a hinting process which helps flesh out the full specification of the plugin. The plugin manager should only deal in concrete terms -- all version finding mumbo jumbo is a customization to base functionality the plugin manager provides. 106
turn an equivalent back on when the RR plugin is released. 116
this will be the basis of the customizable lifecycle execution so need to figure this out quickly. 141
org.apache.maven.plugin.PluginParameterExpressionEvaluator Line
used by the Enforcer plugin 88
don't catch exception 234
don't catch exception 274
don't catch exception 306
don't catch exception 363
without #, this could just be an evaluate call... 418
Copied from the DefaultInterpolator. We likely want to resurrect the PathTranslator or at least a similar component for re-usage 463
org.apache.maven.plugin.PluginParameterExpressionEvaluatorTest Line
Auto-generated method stub 443
org.apache.maven.plugin.internal.DefaultMavenPluginManager Line
could the configuration be passed to lookup and the configurator known to plexus via the descriptor so that this method could entirely be handled by a plexus lookup? 623
figure out how to use the same PluginDescriptor when running mojos 862
org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver Line
We currently cannot tell which <dependencyManagement> section contained the management information. When the resolver provides this information, these log messages should be updated to contain it. 255
org.apache.maven.project.DefaultProjectDependenciesResolver Line
We currently cannot tell which <dependencyManagement> section contained the management information. When the resolver provides this information, these log messages should be updated to contain it. 266
org.apache.maven.project.DuplicateArtifactAttachmentException Line
Make this a checked exception, and modify the API of MavenProjectHelper. Currently, this modification would create compatibility problems for existing plugins. 30
org.apache.maven.project.MavenProject Line
I would like to get rid of this. jvz. 225
let the scope handler deal with this 360
this checking for file == null happens because the resolver has been confused about the root artifact or not. things like the stupid dummy artifact coming from surefire. 372
let the scope handler deal with this 416
this should not be allowed to be null. 478
classpath check doesn't belong here - that's the other method 1595
let the scope handler deal with this 1598
let the scope handler deal with this 1623
classpath check doesn't belong here - that's the other method 1649
let the scope handler deal with this 1700
classpath check doesn't belong here - that's the other method 1725
let the scope handler deal with this 1727
let the scope handler deal with this 1752
classpath check doesn't belong here - that's the other method 1769
let the scope handler deal with this 1772
let the scope handler deal with this 1796
org.apache.maven.project.ProjectBuilderTest Line
a similar test should be created to test the dependency management (basically all usages of DefaultModelBuilder.getCache() are affected by MNG-6530 171
org.apache.maven.project.ProjectSorter Line
!![jc; 28-jul-2005] check this; if we're using '-r' and there are aggregator tasks, this will result in weirdness. 239
org.apache.maven.project.artifact.ActiveProjectArtifact Line
I think this exposes a design flaw in that the immutable and mutable parts of an artifact are in one class and should be split. ie scope, file, etc depend on the context of use, whereas everything else is immutable. 41
org.apache.maven.project.artifact.MavenMetadataSource Line
This prevents a cycle in the composition which shows us another problem we need to deal with. 101
hack: don't rebuild model if it was already loaded during reactor resolution 183
shouldn't the versions be merged across relocations? 676
org.apache.maven.project.artifact.MavenMetadataSourceTest Line
restore these if it makes sense 95
org.apache.maven.repository.TestRepositoryConnector Line
Auto-generated method stub 157
org.apache.maven.repository.TestRepositorySystem Line
Auto-generated method stub 193
Auto-generated method stub 313
org.apache.maven.settings.DefaultMavenSettingsBuilder Line
This replacing shouldn't be necessary as user.home should be in the context of the container and thus the value would be interpolated by Plexus 130
org.apache.maven.settings.SettingsUtilsTest Line
deep compare the lists 121
deep compare the lists 123
org.apache.maven.toolchain.DefaultToolchainManager Line
why is this using the context 127
org.apache.maven.toolchain.RequirementMatcherFactory Line
error reporting 97
org.apache.maven.toolchain.ToolchainFactory Line
keep around?? */ 41