FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 2.0.3

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
77 31 0 0

Files

Class Bugs
org.apache.maven.shared.utils.Expand 2
org.apache.maven.shared.utils.ReaderFactory 1
org.apache.maven.shared.utils.WriterFactory 2
org.apache.maven.shared.utils.cli.CommandLineUtils$1 1
org.apache.maven.shared.utils.cli.StreamPumper 2
org.apache.maven.shared.utils.io.DirectoryScanResult 4
org.apache.maven.shared.utils.io.DirectoryScanner 1
org.apache.maven.shared.utils.io.FileUtils 12
org.apache.maven.shared.utils.io.IOUtil 3
org.apache.maven.shared.utils.io.MatchPattern 1
org.apache.maven.shared.utils.io.WalkCollector 1
org.apache.maven.shared.utils.xml.XmlStreamWriter 1

org.apache.maven.shared.utils.Expand

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.Expand.extractFile(File, File, InputStream, String, Date, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 184 Medium
Exceptional return value of java.io.File.setLastModified(long) ignored in org.apache.maven.shared.utils.Expand.extractFile(File, File, InputStream, String, Date, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 209 Medium

org.apache.maven.shared.utils.ReaderFactory

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.shared.utils.ReaderFactory.newPlatformReader(File): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 154 High

org.apache.maven.shared.utils.WriterFactory

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.shared.utils.WriterFactory.newPlatformWriter(File): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 146 High
Found reliance on default encoding in org.apache.maven.shared.utils.WriterFactory.newPlatformWriter(OutputStream): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 132 High

org.apache.maven.shared.utils.cli.CommandLineUtils$1

Bug Category Details Line Priority
org.apache.maven.shared.utils.cli.CommandLineUtils$1.call() explicitly invokes run on a thread (did you mean to start it instead?) MT_CORRECTNESS RU_INVOKE_RUN 315 High

org.apache.maven.shared.utils.cli.StreamPumper

Bug Category Details Line Priority
Found reliance on default encoding in new org.apache.maven.shared.utils.cli.StreamPumper(InputStream, StreamConsumer): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 57 High
Found reliance on default encoding in new org.apache.maven.shared.utils.cli.StreamPumper(InputStream, StreamConsumer, Charset): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 62 High

org.apache.maven.shared.utils.io.DirectoryScanResult

Bug Category Details Line Priority
org.apache.maven.shared.utils.io.DirectoryScanResult.getFilesAdded() may expose internal representation by returning DirectoryScanResult.filesAdded MALICIOUS_CODE EI_EXPOSE_REP 44 Medium
org.apache.maven.shared.utils.io.DirectoryScanResult.getFilesRemoved() may expose internal representation by returning DirectoryScanResult.filesRemoved MALICIOUS_CODE EI_EXPOSE_REP 52 Medium
new org.apache.maven.shared.utils.io.DirectoryScanResult(String[], String[]) may expose internal representation by storing an externally mutable object into DirectoryScanResult.filesAdded MALICIOUS_CODE EI_EXPOSE_REP2 35 Medium
new org.apache.maven.shared.utils.io.DirectoryScanResult(String[], String[]) may expose internal representation by storing an externally mutable object into DirectoryScanResult.filesRemoved MALICIOUS_CODE EI_EXPOSE_REP2 36 Medium

org.apache.maven.shared.utils.io.DirectoryScanner

Bug Category Details Line Priority
org.apache.maven.shared.utils.io.DirectoryScanner.DEFAULTEXCLUDES should be package protected MALICIOUS_CODE MS_PKGPROTECT 118 Medium

org.apache.maven.shared.utils.io.FileUtils

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.copyFile(File, File, String, FileUtils$FilterWrapper[], boolean): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 1897 High
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.copyFile(File, File, String, FileUtils$FilterWrapper[], boolean): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 1898 High
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileAppend(String, String, String): String.getBytes() I18N DM_DEFAULT_ENCODING 352 High
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileRead(File, String): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 286 High
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileWrite(File, String, String): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 411 High
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.fileWriteArray(File, String, String[]): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 456 High
Found reliance on default encoding in org.apache.maven.shared.utils.io.FileUtils.loadFile(File): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 1948 High
org.apache.maven.shared.utils.io.FileUtils.deleteFile(File) forces garbage collection; extremely dubious except in benchmarking code PERFORMANCE DM_GC 1225 High
org.apache.maven.shared.utils.io.FileUtils.normalize(String) may return null, but is declared @NonNull CORRECTNESS NP_NONNULL_RETURN_VIOLATION 1029 High
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.copyStreamToFile(InputStream, File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 956 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.mkdir(String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 604 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.mkdirsFor(File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 848 Medium

org.apache.maven.shared.utils.io.IOUtil

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(InputStream, Writer, int): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 215 High
Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(Reader, OutputStream, int): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 361 High
Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(String, OutputStream, int): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 446 High

org.apache.maven.shared.utils.io.MatchPattern

Bug Category Details Line Priority
org.apache.maven.shared.utils.io.MatchPattern.getTokenizedPathString() may expose internal representation by returning MatchPattern.tokenized MALICIOUS_CODE EI_EXPOSE_REP 106 Medium

org.apache.maven.shared.utils.io.WalkCollector

Bug Category Details Line Priority
Unread field: org.apache.maven.shared.utils.io.WalkCollector.startingDir PERFORMANCE URF_UNREAD_FIELD 60 Medium

org.apache.maven.shared.utils.xml.XmlStreamWriter

Bug Category Details Line Priority
The class name org.apache.maven.shared.utils.xml.XmlStreamWriter shadows the simple name of the superclass org.apache.commons.io.output.XmlStreamWriter BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 35-42 High