FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
79 27 0 0

org.apache.maven.shared.utils.PropertyUtils

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.apache.maven.shared.utils.PropertyUtils.loadProperties(File) STYLE REC_CATCH_EXCEPTION 83 Medium
Exception is caught when Exception is not thrown in org.apache.maven.shared.utils.PropertyUtils.loadProperties(InputStream) STYLE REC_CATCH_EXCEPTION 119 Medium
Exception is caught when Exception is not thrown in org.apache.maven.shared.utils.PropertyUtils.loadProperties(URL) STYLE REC_CATCH_EXCEPTION 62 Medium

org.apache.maven.shared.utils.ReaderFactory

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.shared.utils.ReaderFactory.newPlatformReader(File): new java.io.FileReader(File) I18N DM_DEFAULT_ENCODING 165 High

org.apache.maven.shared.utils.WriterFactory

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.shared.utils.WriterFactory.newPlatformWriter(File): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 159 High
Found reliance on default encoding in org.apache.maven.shared.utils.WriterFactory.newPlatformWriter(OutputStream): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 144 High

org.apache.maven.shared.utils.cli.Commandline

Bug Category Details Line Priority
org.apache.maven.shared.utils.cli.Commandline.getEnvironmentVariables() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 233 Medium

org.apache.maven.shared.utils.cli.StreamFeeder

Bug Category Details Line Priority
Naked notify in org.apache.maven.shared.utils.cli.StreamFeeder.run() MT_CORRECTNESS NN_NAKED_NOTIFY 76 Medium

org.apache.maven.shared.utils.cli.StreamPumper

Bug Category Details Line Priority
Found reliance on default encoding in new org.apache.maven.shared.utils.cli.StreamPumper(InputStream, StreamConsumer): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 53 High
Found reliance on default encoding in new org.apache.maven.shared.utils.cli.StreamPumper(InputStream, StreamConsumer, Charset): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 63 High

org.apache.maven.shared.utils.io.DirectoryScanResult

Bug Category Details Line Priority
org.apache.maven.shared.utils.io.DirectoryScanResult.getFilesAdded() may expose internal representation by returning DirectoryScanResult.filesAdded MALICIOUS_CODE EI_EXPOSE_REP 51 Medium
org.apache.maven.shared.utils.io.DirectoryScanResult.getFilesRemoved() may expose internal representation by returning DirectoryScanResult.filesRemoved MALICIOUS_CODE EI_EXPOSE_REP 59 Medium
new org.apache.maven.shared.utils.io.DirectoryScanResult(String[], String[]) may expose internal representation by storing an externally mutable object into DirectoryScanResult.filesAdded MALICIOUS_CODE EI_EXPOSE_REP2 42 Medium
new org.apache.maven.shared.utils.io.DirectoryScanResult(String[], String[]) may expose internal representation by storing an externally mutable object into DirectoryScanResult.filesRemoved MALICIOUS_CODE EI_EXPOSE_REP2 43 Medium

org.apache.maven.shared.utils.io.DirectoryScanner

Bug Category Details Line Priority
org.apache.maven.shared.utils.io.DirectoryScanner.DEFAULTEXCLUDES should be package protected MALICIOUS_CODE MS_PKGPROTECT 129 Medium

org.apache.maven.shared.utils.io.FileUtils

Bug Category Details Line Priority
org.apache.maven.shared.utils.io.FileUtils.normalize(String) may return null, but is declared @Nonnull CORRECTNESS NP_NONNULL_RETURN_VIOLATION 1014 High
org.apache.maven.shared.utils.io.FileUtils.copyStreamToFile(InputStream, File) may fail to clean up java.io.InputStream on checked exception EXPERIMENTAL OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE 940 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.copyStreamToFile(InputStream, File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 943 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.mkdir(String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 600 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.shared.utils.io.FileUtils.mkdirsFor(File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 841 Medium

org.apache.maven.shared.utils.io.IOUtil

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(InputStream, Writer, int): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 247 High
Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(Reader, OutputStream, int): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 446 High
Found reliance on default encoding in org.apache.maven.shared.utils.io.IOUtil.copy(String, OutputStream, int): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 562 High

org.apache.maven.shared.utils.io.MatchPattern

Bug Category Details Line Priority
org.apache.maven.shared.utils.io.MatchPattern.getTokenizedPathString() may expose internal representation by returning MatchPattern.tokenized MALICIOUS_CODE EI_EXPOSE_REP 121 Medium

org.apache.maven.shared.utils.io.WalkCollector

Bug Category Details Line Priority
Unread field: org.apache.maven.shared.utils.io.WalkCollector.startingDir PERFORMANCE URF_UNREAD_FIELD 66 Medium

org.apache.maven.shared.utils.logging.MessageUtils

Bug Category Details Line Priority
Incorrect lazy initialization and update of static field org.apache.maven.shared.utils.logging.MessageUtils.shutdownHook in org.apache.maven.shared.utils.logging.MessageUtils.registerShutdownHook() MT_CORRECTNESS LI_LAZY_INIT_UPDATE_STATIC 199-202 High

org.apache.maven.shared.utils.xml.XmlStreamWriter

Bug Category Details Line Priority
The class name org.apache.maven.shared.utils.xml.XmlStreamWriter shadows the simple name of the superclass org.apache.commons.io.output.XmlStreamWriter BAD_PRACTICE NM_SAME_SIMPLE_NAME_AS_SUPERCLASS 38-49 High