Fork me on GitHub

FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
111 19 0 0

org.apache.maven.plugin.surefire.AbstractSurefireMojo

Bug Category Details Line Priority
org.apache.maven.plugin.surefire.AbstractSurefireMojo.getAdditionalClasspathElements() may expose internal representation by returning AbstractSurefireMojo.additionalClasspathElements MALICIOUS_CODE EI_EXPOSE_REP 3714 Medium
org.apache.maven.plugin.surefire.AbstractSurefireMojo.getClasspathDependencyExcludes() may expose internal representation by returning AbstractSurefireMojo.classpathDependencyExcludes MALICIOUS_CODE EI_EXPOSE_REP 3724 Medium
org.apache.maven.plugin.surefire.AbstractSurefireMojo.getDependenciesToScan() may expose internal representation by returning AbstractSurefireMojo.dependenciesToScan MALICIOUS_CODE EI_EXPOSE_REP 3666 Medium
org.apache.maven.plugin.surefire.AbstractSurefireMojo.setAdditionalClasspathElements(String[]) may expose internal representation by storing an externally mutable object into AbstractSurefireMojo.additionalClasspathElements MALICIOUS_CODE EI_EXPOSE_REP2 3719 Medium
org.apache.maven.plugin.surefire.AbstractSurefireMojo.setClasspathDependencyExcludes(String[]) may expose internal representation by storing an externally mutable object into AbstractSurefireMojo.classpathDependencyExcludes MALICIOUS_CODE EI_EXPOSE_REP2 3729 Medium
org.apache.maven.plugin.surefire.AbstractSurefireMojo.setDependenciesToScan(String[]) may expose internal representation by storing an externally mutable object into AbstractSurefireMojo.dependenciesToScan MALICIOUS_CODE EI_EXPOSE_REP2 3671 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.AbstractSurefireMojo.createSurefireBootDirectoryInBuild() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 3142 Medium
Exceptional return value of java.io.File.delete() ignored in org.apache.maven.plugin.surefire.AbstractSurefireMojo.createSurefireBootDirectoryInTemp() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 3166 Medium

org.apache.maven.plugin.surefire.SurefireHelper

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.apache.maven.plugin.surefire.SurefireHelper.commandLineOptions(MavenSession, PluginConsoleLogger) STYLE REC_CATCH_EXCEPTION 156 Medium

org.apache.maven.plugin.surefire.SurefireProperties

Bug Category Details Line Priority
org.apache.maven.plugin.surefire.SurefireProperties doesn't override java.util.Hashtable.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium
org.apache.maven.plugin.surefire.SurefireProperties.copyProperties(Properties, Map) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 176 Medium

org.apache.maven.plugin.surefire.booterclient.ForkStarter

Bug Category Details Line Priority
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(Object, KeyValueSource, ForkClient, SurefireProperties, int, AbstractForkInputStream, boolean) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 666 Medium

org.apache.maven.plugin.surefire.booterclient.ModularClasspathForkConfiguration

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.plugin.surefire.booterclient.ModularClasspathForkConfiguration.createArgsFile(File, List, List, Collection, File, String): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 123 High

org.apache.maven.plugin.surefire.booterclient.lazytestprovider.OutputStreamFlushableCommandline$OutputStreamFlushReceiver

Bug Category Details Line Priority
Should org.apache.maven.plugin.surefire.booterclient.lazytestprovider.OutputStreamFlushableCommandline$OutputStreamFlushReceiver be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 41-56 Medium

org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer

Bug Category Details Line Priority
Comparison of String parameter using == or != in org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer.shouldStopQueueing(String) BAD_PRACTICE ES_COMPARING_PARAMETER_STRING_WITH_EQ 166 Medium

org.apache.maven.plugin.surefire.report.ConsoleOutputFileReporter

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.report.ConsoleOutputFileReporter.writeTestOutput(byte[], int, int, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 116 Medium

org.apache.maven.plugin.surefire.report.FileReporter

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.report.FileReporter.testSetStarting(ReportEntry) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 64 Medium

org.apache.maven.plugin.surefire.report.StatelessXmlReporter

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.report.StatelessXmlReporter.getOutputStream(WrappedReportEntry) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 289 Medium

org.apache.maven.surefire.providerapi.ServiceLoader

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.surefire.providerapi.ServiceLoader.getReader(URL): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 171 High