Fork me on GitHub

FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
144 19 0 0

Files

Class Bugs
org.apache.maven.plugin.surefire.AbstractSurefireMojo 10
org.apache.maven.plugin.surefire.SurefireProperties 2
org.apache.maven.plugin.surefire.booterclient.ForkStarter 1
org.apache.maven.plugin.surefire.booterclient.ModularClasspathForkConfiguration 1
org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer 1
org.apache.maven.plugin.surefire.report.ConsoleOutputFileReporter 1
org.apache.maven.plugin.surefire.report.FileReporter 1
org.apache.maven.plugin.surefire.report.StatelessXmlReporter 1
org.apache.maven.surefire.providerapi.ServiceLoader 1

org.apache.maven.plugin.surefire.AbstractSurefireMojo

Bug Category Details Line Priority
org.apache.maven.plugin.surefire.AbstractSurefireMojo.getAdditionalClasspathElements() may expose internal representation by returning AbstractSurefireMojo.additionalClasspathElements MALICIOUS_CODE EI_EXPOSE_REP 3803 Medium
org.apache.maven.plugin.surefire.AbstractSurefireMojo.getClasspathDependencyExcludes() may expose internal representation by returning AbstractSurefireMojo.classpathDependencyExcludes MALICIOUS_CODE EI_EXPOSE_REP 3813 Medium
org.apache.maven.plugin.surefire.AbstractSurefireMojo.getDependenciesToScan() may expose internal representation by returning AbstractSurefireMojo.dependenciesToScan MALICIOUS_CODE EI_EXPOSE_REP 3749 Medium
org.apache.maven.plugin.surefire.AbstractSurefireMojo.setAdditionalClasspathElements(String[]) may expose internal representation by storing an externally mutable object into AbstractSurefireMojo.additionalClasspathElements MALICIOUS_CODE EI_EXPOSE_REP2 3808 Medium
org.apache.maven.plugin.surefire.AbstractSurefireMojo.setClasspathDependencyExcludes(String[]) may expose internal representation by storing an externally mutable object into AbstractSurefireMojo.classpathDependencyExcludes MALICIOUS_CODE EI_EXPOSE_REP2 3818 Medium
org.apache.maven.plugin.surefire.AbstractSurefireMojo.setDependenciesToScan(String[]) may expose internal representation by storing an externally mutable object into AbstractSurefireMojo.dependenciesToScan MALICIOUS_CODE EI_EXPOSE_REP2 3754 Medium
Inconsistent synchronization of org.apache.maven.plugin.surefire.AbstractSurefireMojo.logger; locked 50% of time MT_CORRECTNESS IS2_INCONSISTENT_SYNC 895 Medium
Possible null pointer dereference in org.apache.maven.plugin.surefire.AbstractSurefireMojo.createStartupConfiguration(ProviderInfo, boolean, ClassLoaderConfiguration, DefaultScanResult, Platform, TestClassPath) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 1775 Medium
Possible null pointer dereference in org.apache.maven.plugin.surefire.AbstractSurefireMojo.createStartupConfiguration(ProviderInfo, boolean, ClassLoaderConfiguration, DefaultScanResult, Platform, TestClassPath) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 1776 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.AbstractSurefireMojo.createSurefireBootDirectoryInBuild() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 3311 Medium

org.apache.maven.plugin.surefire.SurefireProperties

Bug Category Details Line Priority
org.apache.maven.plugin.surefire.SurefireProperties doesn't override java.util.Hashtable.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium
org.apache.maven.plugin.surefire.SurefireProperties.copyProperties(Properties, Map) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 176 Medium

org.apache.maven.plugin.surefire.booterclient.ForkStarter

Bug Category Details Line Priority
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(Object, KeyValueSource, ForkClient, SurefireProperties, int, AbstractForkInputStream, boolean) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 685 Medium

org.apache.maven.plugin.surefire.booterclient.ModularClasspathForkConfiguration

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.plugin.surefire.booterclient.ModularClasspathForkConfiguration.createArgsFile(String, List, List, Collection, File, String): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 125 High

org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer

Bug Category Details Line Priority
Comparison of String parameter using == or != in org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer.shouldStopQueueing(String) BAD_PRACTICE ES_COMPARING_PARAMETER_STRING_WITH_EQ 166 Medium

org.apache.maven.plugin.surefire.report.ConsoleOutputFileReporter

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.report.ConsoleOutputFileReporter.writeTestOutput(String, boolean, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 126 Medium

org.apache.maven.plugin.surefire.report.FileReporter

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.report.FileReporter.testSetCompleted(WrappedReportEntry, TestSetStats, List) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 78 Medium

org.apache.maven.plugin.surefire.report.StatelessXmlReporter

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.report.StatelessXmlReporter.getOutputStream(WrappedReportEntry) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 348 Medium

org.apache.maven.surefire.providerapi.ServiceLoader

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.surefire.providerapi.ServiceLoader.getReader(URL): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 149 High