Fork me on GitHub

FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 2.0.3

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
77 40 0 0

Files

Class Bugs
org.apache.maven.archetype.DefaultArchetypeManager 1
org.apache.maven.archetype.common.DefaultArchetypeArtifactManager 3
org.apache.maven.archetype.common.DefaultArchetypeFilesResolver 1
org.apache.maven.archetype.common.DefaultPomManager 2
org.apache.maven.archetype.common.MavenJDOMWriter 1
org.apache.maven.archetype.common.MavenJDOMWriter$Counter 1
org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy 3
org.apache.maven.archetype.common.util.ListScanner 2
org.apache.maven.archetype.common.util.XMLOutputter$NamespaceStack 1
org.apache.maven.archetype.creator.FilesetArchetypeCreator 12
org.apache.maven.archetype.generator.DefaultArchetypeGenerator 1
org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator 4
org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader 4
org.apache.maven.archetype.old.DefaultOldArchetype 2
org.apache.maven.archetype.old.descriptor.TemplateDescriptor 1
org.apache.maven.archetype.source.RemoteCatalogArchetypeDataSource 1

org.apache.maven.archetype.DefaultArchetypeManager

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.DefaultArchetypeManager.zip(File, File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 93 Medium

org.apache.maven.archetype.common.DefaultArchetypeArtifactManager

Bug Category Details Line Priority
org.apache.maven.archetype.common.DefaultArchetypeArtifactManager.getArchetypeJarLoader(File) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block MALICIOUS_CODE DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED 108 Medium
Load of known null value in org.apache.maven.archetype.common.DefaultArchetypeArtifactManager.loadFileSetArchetypeDescriptor(ZipFile) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 484 Medium
Load of known null value in org.apache.maven.archetype.common.DefaultArchetypeArtifactManager.loadOldArchetypeDescriptor(ZipFile) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 514 Medium

org.apache.maven.archetype.common.DefaultArchetypeFilesResolver

Bug Category Details Line Priority
org.apache.maven.archetype.common.DefaultArchetypeFilesResolver.resolveFiles(File, List) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 308 Medium

org.apache.maven.archetype.common.DefaultPomManager

Bug Category Details Line Priority
org.apache.maven.archetype.common.DefaultPomManager.mergeModelBase(ModelBase, ModelBase) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 447 Medium
org.apache.maven.archetype.common.DefaultPomManager.mergeReportPlugins(Model, Model) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 480 Medium

org.apache.maven.archetype.common.MavenJDOMWriter

Bug Category Details Line Priority
org.apache.maven.archetype.common.MavenJDOMWriter.findAndReplaceProperties(MavenJDOMWriter$Counter, Element, String, Map) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 198 Medium

org.apache.maven.archetype.common.MavenJDOMWriter$Counter

Bug Category Details Line Priority
Should org.apache.maven.archetype.common.MavenJDOMWriter$Counter be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 2304-2346 Medium

org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in new org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy(Format, String) STYLE REC_CATCH_EXCEPTION 500 Medium
Exception is caught when Exception is not thrown in org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy.shouldEscape(char) STYLE REC_CATCH_EXCEPTION 529 Medium
Should org.apache.maven.archetype.common.util.Format$DefaultEscapeStrategy be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 470-536 Medium

org.apache.maven.archetype.common.util.ListScanner

Bug Category Details Line Priority
org.apache.maven.archetype.common.util.ListScanner.DEFAULTEXCLUDES is a mutable array MALICIOUS_CODE MS_MUTABLE_ARRAY 118 High
Unread public/protected field: org.apache.maven.archetype.common.util.ListScanner.everythingIncluded STYLE URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD 157 Medium

org.apache.maven.archetype.common.util.XMLOutputter$NamespaceStack

Bug Category Details Line Priority
Should org.apache.maven.archetype.common.util.XMLOutputter$NamespaceStack be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 1790 Medium

org.apache.maven.archetype.creator.FilesetArchetypeCreator

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetype(ArchetypeCreationRequest, ArchetypeCreationResult) STYLE REC_CATCH_EXCEPTION 250 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.copyFiles(File, File, String, List, boolean, String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 768 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetype(ArchetypeCreationRequest, ArchetypeCreationResult) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 133 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypeBasicIt(ArchetypeDescriptor, File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 271 Medium
Exceptional return value of java.io.File.delete() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypePom(Model, File, Properties, File, boolean, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 844 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypePom(Model, File, Properties, File, boolean, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 832 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createArchetypeProjectPom(MavenProject, ArtifactRepository, Properties, File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 418 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModule(Properties, String, String, String, File, File, List, List, String, boolean, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 962 Medium
Exceptional return value of java.io.File.delete() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModulePom(Model, String, File, Properties, File, boolean, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 1067 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.createModulePom(Model, String, File, Properties, File, boolean, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 1055 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.creator.FilesetArchetypeCreator.processFileSet(File, File, String, List, boolean, String, Properties, String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 1278 Medium
org.apache.maven.archetype.creator.FilesetArchetypeCreator.createFileSets(List, int, boolean, String, boolean, String) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 937 Medium

org.apache.maven.archetype.generator.DefaultArchetypeGenerator

Bug Category Details Line Priority
Possible null pointer dereference of request in org.apache.maven.archetype.generator.DefaultArchetypeGenerator.getArchetypeFile(ArchetypeGenerationRequest, ArtifactRepository) CORRECTNESS NP_NULL_ON_SOME_PATH 81 Medium

org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.copyFile(File, String, boolean, ZipFile) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 271 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processFilesetModule(String, String, List, File, ZipFile, String, File, File, String, AbstractArchetypeDescriptor, Context) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 557 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processTemplate(File, Context, String, String, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 717 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.generator.DefaultFilesetArchetypeGenerator.processTemplates(String, File, Context, AbstractArchetypeDescriptor, List, ZipFile, String, boolean) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 777 Medium

org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getIntegerValue(String, String, XmlPullParser, boolean) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 392 High
Boxing/unboxing to parse a primitive org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getLongValue(String, String, XmlPullParser, boolean) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 422 High
Private method org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 177 Medium
Private method org.apache.maven.archetype.model.io.xpp3.ArchetypeXpp3Reader.getDateValue(String, String, XmlPullParser) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 265 Medium

org.apache.maven.archetype.old.DefaultOldArchetype

Bug Category Details Line Priority
org.apache.maven.archetype.old.DefaultOldArchetype.createArchetype(ArchetypeGenerationRequest, File) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block MALICIOUS_CODE DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED 178 Medium
Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.archetype.old.DefaultOldArchetype.processTemplate(String, Context, String, TemplateDescriptor, boolean, String, String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 836 Medium

org.apache.maven.archetype.old.descriptor.TemplateDescriptor

Bug Category Details Line Priority
Found reliance on default encoding in org.apache.maven.archetype.old.descriptor.TemplateDescriptor.getDefaultEncoding(): new java.io.OutputStreamWriter(OutputStream) I18N DM_DEFAULT_ENCODING 67 High

org.apache.maven.archetype.source.RemoteCatalogArchetypeDataSource

Bug Category Details Line Priority
Exceptional return value of java.io.File.delete() ignored in org.apache.maven.archetype.source.RemoteCatalogArchetypeDataSource.downloadCatalog(String, String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 126 Medium