FindBugs Bug Detector Report
The following document contains the results of FindBugs Report
FindBugs Version is 2.0.1
Threshold is medium
Effort is min
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 67 |
31 |
0 |
0 |
org.apache.maven.plugin.surefire.AbstractSurefireMojo
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.plugin.surefire.AbstractSurefireMojo.getAdditionalClasspathElements() may expose internal representation by returning AbstractSurefireMojo.additionalClasspathElements |
MALICIOUS_CODE |
EI_EXPOSE_REP |
2686 |
Medium |
| org.apache.maven.plugin.surefire.AbstractSurefireMojo.getClasspathDependencyExcludes() may expose internal representation by returning AbstractSurefireMojo.classpathDependencyExcludes |
MALICIOUS_CODE |
EI_EXPOSE_REP |
2696 |
Medium |
| org.apache.maven.plugin.surefire.AbstractSurefireMojo.getDependenciesToScan() may expose internal representation by returning AbstractSurefireMojo.dependenciesToScan |
MALICIOUS_CODE |
EI_EXPOSE_REP |
2640 |
Medium |
| org.apache.maven.plugin.surefire.AbstractSurefireMojo.getSuiteXmlFiles() may expose internal representation by returning AbstractSurefireMojo.suiteXmlFiles |
MALICIOUS_CODE |
EI_EXPOSE_REP |
2422 |
Medium |
| org.apache.maven.plugin.surefire.AbstractSurefireMojo.setAdditionalClasspathElements(String[]) may expose internal representation by storing an externally mutable object into AbstractSurefireMojo.additionalClasspathElements |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
2691 |
Medium |
| org.apache.maven.plugin.surefire.AbstractSurefireMojo.setClasspathDependencyExcludes(String[]) may expose internal representation by storing an externally mutable object into AbstractSurefireMojo.classpathDependencyExcludes |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
2701 |
Medium |
| org.apache.maven.plugin.surefire.AbstractSurefireMojo.setDependenciesToScan(String[]) may expose internal representation by storing an externally mutable object into AbstractSurefireMojo.dependenciesToScan |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
2645 |
Medium |
| org.apache.maven.plugin.surefire.AbstractSurefireMojo.setSuiteXmlFiles(File[]) may expose internal representation by storing an externally mutable object into AbstractSurefireMojo.suiteXmlFiles |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
2428 |
Medium |
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.AbstractSurefireMojo.getForkConfiguration() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
1507 |
Medium |
org.apache.maven.plugin.surefire.SurefireProperties
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.plugin.surefire.SurefireProperties doesn't override java.util.Hashtable.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
725-754 |
Medium |
| org.apache.maven.plugin.surefire.SurefireProperties.copyProperties(Properties, Map) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
175 |
Medium |
| org.apache.maven.plugin.surefire.SurefireProperties.copyPropertiesFrom(Properties) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
101 |
Medium |
| org.apache.maven.plugin.surefire.SurefireProperties.copyTo(Map) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
193 |
Medium |
org.apache.maven.plugin.surefire.booterclient.ForkConfiguration
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.plugin.surefire.booterclient.ForkConfiguration.createJar(List, String) concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
237 |
Medium |
org.apache.maven.plugin.surefire.booterclient.ForkStarter$InputStreamCloser
| Bug |
Category |
Details |
Line |
Priority |
| Should org.apache.maven.plugin.surefire.booterclient.ForkStarter$InputStreamCloser be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
96-114 |
Medium |
org.apache.maven.plugin.surefire.booterclient.MockReporter
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.plugin.surefire.booterclient.MockReporter.writeTestOutput(byte[], int, int, boolean): new String(byte[], int, int) |
I18N |
DM_DEFAULT_ENCODING |
158 |
High |
org.apache.maven.plugin.surefire.booterclient.ProviderDetector
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.plugin.surefire.booterclient.ProviderDetector.getReader(URL): new java.io.InputStreamReader(InputStream) |
I18N |
DM_DEFAULT_ENCODING |
125 |
High |
org.apache.maven.plugin.surefire.booterclient.lazytestprovider.OutputStreamFlushableCommandline$OutputStreamFlushReceiver
| Bug |
Category |
Details |
Line |
Priority |
| Should org.apache.maven.plugin.surefire.booterclient.lazytestprovider.OutputStreamFlushableCommandline$OutputStreamFlushReceiver be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
41-55 |
Medium |
org.apache.maven.plugin.surefire.booterclient.lazytestprovider.TestProvidingInputStream
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.plugin.surefire.booterclient.lazytestprovider.TestProvidingInputStream.read(): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
92 |
High |
| Inconsistent synchronization of org.apache.maven.plugin.surefire.booterclient.lazytestprovider.TestProvidingInputStream.flushReceiverProvider; locked 75% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
68 |
Medium |
org.apache.maven.plugin.surefire.report.ConsoleOutputFileReporter
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.plugin.surefire.report.ConsoleOutputFileReporter.writeTestOutput(byte[], int, int, boolean): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
89 |
High |
| Found reliance on default encoding in org.apache.maven.plugin.surefire.report.ConsoleOutputFileReporter.writeTestOutput(byte[], int, int, boolean): new String(byte[], int, int) |
I18N |
DM_DEFAULT_ENCODING |
91 |
High |
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.report.ConsoleOutputFileReporter.writeTestOutput(byte[], int, int, boolean) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
85 |
Medium |
org.apache.maven.plugin.surefire.report.ConsoleReporter
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in new org.apache.maven.plugin.surefire.report.ConsoleReporter(PrintStream): new java.io.OutputStreamWriter(OutputStream) |
I18N |
DM_DEFAULT_ENCODING |
51 |
High |
org.apache.maven.plugin.surefire.report.FileReporter
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.plugin.surefire.report.FileReporter.testSetStarting(ReportEntry): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
71 |
High |
| exceptional return value of java.io.File.delete() ignored in org.apache.maven.plugin.surefire.report.FileReporter.testSetStarting(ReportEntry) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
66 |
Medium |
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.report.FileReporter.testSetStarting(ReportEntry) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
61 |
Medium |
org.apache.maven.plugin.surefire.report.StatelessXmlReporter
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.plugin.surefire.report.StatelessXmlReporter.<static initializer>(): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
76 |
High |
| exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.plugin.surefire.report.StatelessXmlReporter.getOutputStream(WrappedReportEntry) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
152 |
Medium |
| Unread field: org.apache.maven.plugin.surefire.report.StatelessXmlReporter.encoding; should this field be static? |
PERFORMANCE |
SS_SHOULD_BE_STATIC |
84 |
Medium |
org.apache.maven.plugin.surefire.util.DependencyScanner$Matcher
| Bug |
Category |
Details |
Line |
Priority |
| Should org.apache.maven.plugin.surefire.util.DependencyScanner$Matcher be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
148-172 |
Medium |
