FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 2.0.3
Threshold is medium
Effort is min
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 96 |
23 |
0 |
0 |
org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap.fromFile(File): new java.io.FileReader(File) |
I18N |
DM_DEFAULT_ENCODING |
66 |
High |
| Found reliance on default encoding in org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap.serialize(File): new java.io.PrintWriter(OutputStream) |
I18N |
DM_DEFAULT_ENCODING |
105 |
High |
org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$LeastFailureComparator
| Bug |
Category |
Details |
Line |
Priority |
| Should org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$LeastFailureComparator be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
246-251 |
Medium |
org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$PrioritizedTestComparator
| Bug |
Category |
Details |
Line |
Priority |
| Should org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$PrioritizedTestComparator be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
228-233 |
Medium |
org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$RunCountComparator
| Bug |
Category |
Details |
Line |
Priority |
| Should org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$RunCountComparator be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
140-146 |
Medium |
org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$TestRuntimeComparator
| Bug |
Category |
Details |
Line |
Priority |
| Should org.apache.maven.plugin.surefire.runorder.RunEntryStatisticsMap$TestRuntimeComparator be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
237-242 |
Medium |
org.apache.maven.surefire.booter.MasterProcessReader$CommandRunnable
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.apache.maven.surefire.booter.MasterProcessReader$CommandRunnable.exitByConfiguration() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
534-539 |
Medium |
org.apache.maven.surefire.booter.Shutdown
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.surefire.booter.Shutdown.listParameters() concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
68 |
Medium |
org.apache.maven.surefire.booter.SurefireReflector$ClassLoaderProxy
| Bug |
Category |
Details |
Line |
Priority |
| Should org.apache.maven.surefire.booter.SurefireReflector$ClassLoaderProxy be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
166-174 |
Medium |
org.apache.maven.surefire.report.ConsoleOutputCapture$ForwardingPrintStream
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in new org.apache.maven.surefire.report.ConsoleOutputCapture$ForwardingPrintStream(boolean, ConsoleOutputReceiver): new org.apache.maven.surefire.report.ConsoleOutputCapture$ForwardingPrintStream(OutputStream) |
I18N |
DM_DEFAULT_ENCODING |
48 |
High |
| Found reliance on default encoding in org.apache.maven.surefire.report.ConsoleOutputCapture$ForwardingPrintStream.println(String): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
86 |
High |
org.apache.maven.surefire.suite.RunResult
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.surefire.suite.RunResult.getStackTrace(Exception): new java.io.PrintWriter(OutputStream) |
I18N |
DM_DEFAULT_ENCODING |
119 |
High |
| Found reliance on default encoding in org.apache.maven.surefire.suite.RunResult.getStackTrace(Exception): new String(byte[]) |
I18N |
DM_DEFAULT_ENCODING |
122 |
High |
| Found reliance on default encoding in org.apache.maven.surefire.suite.RunResult.writeSummary(File, boolean, String): new java.io.FileWriter(File) |
I18N |
DM_DEFAULT_ENCODING |
273 |
High |
| Exceptional return value of java.io.File.mkdirs() ignored in org.apache.maven.surefire.suite.RunResult.writeSummary(File, boolean, String) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
257 |
Medium |
org.apache.maven.surefire.testset.DirectoryScannerParameters
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.surefire.testset.DirectoryScannerParameters.getRunOrder() may expose internal representation by returning DirectoryScannerParameters.runOrder |
MALICIOUS_CODE |
EI_EXPOSE_REP |
108 |
Medium |
org.apache.maven.surefire.testset.ResolvedTest
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.surefire.testset.ResolvedTest.toString() may return null |
BAD_PRACTICE |
NP_TOSTRING_COULD_RETURN_NULL |
218 |
Medium |
org.apache.maven.surefire.testset.RunOrderParameters
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.surefire.testset.RunOrderParameters.getRunOrder() may expose internal representation by returning RunOrderParameters.runOrder |
MALICIOUS_CODE |
EI_EXPOSE_REP |
53 |
Medium |
| new org.apache.maven.surefire.testset.RunOrderParameters(RunOrder[], File) may expose internal representation by storing an externally mutable object into RunOrderParameters.runOrder |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
36 |
Medium |
org.apache.maven.surefire.testset.TestListResolver
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.surefire.testset.TestListResolver.aggregatedTest(String, Set) concatenates strings using + in a loop |
PERFORMANCE |
SBSC_USE_STRINGBUFFER_CONCATENATION |
343 |
Medium |
org.apache.maven.surefire.util.RunOrder
| Bug |
Category |
Details |
Line |
Priority |
| org.apache.maven.surefire.util.RunOrder.DEFAULT is a mutable array |
MALICIOUS_CODE |
MS_MUTABLE_ARRAY |
47 |
High |
org.apache.maven.surefire.util.internal.ByteBuffer
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.apache.maven.surefire.util.internal.ByteBuffer.toString(): new String(byte[], int, int) |
I18N |
DM_DEFAULT_ENCODING |
109 |
High |
| org.apache.maven.surefire.util.internal.ByteBuffer.getData() may expose internal representation by returning ByteBuffer.data |
MALICIOUS_CODE |
EI_EXPOSE_REP |
99 |
Medium |
