The following document contains the results of FindBugs Report
FindBugs Version is 1.3.9
Threshold is medium
Effort is min
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugin.eclipse.ConfigureWorkspaceMojo.workspaceActiveCodeStyleProfileName | CORRECTNESS | UWF_UNWRITTEN_FIELD | 70 | Medium |
| Unwritten field: org.apache.maven.plugin.eclipse.ConfigureWorkspaceMojo.workspaceCodeStylesURL | CORRECTNESS | UWF_UNWRITTEN_FIELD | 59 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugin.eclipse.EclipseCleanMojo.additionalConfig | CORRECTNESS | UWF_UNWRITTEN_FIELD | 106 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.EclipsePlugin.WTP_SUPPORTED_VERSIONS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 156 | Medium |
| org.apache.maven.plugin.eclipse.EclipsePlugin.extractResourceDirs(Set, List, File, File, boolean, String) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1775 | Medium |
| org.apache.maven.plugin.eclipse.EclipsePlugin.writeAdditionalConfig() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1258 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.maven.plugin.eclipse.EclipseToMavenMojo.execute() invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead | PERFORMANCE | DM_NUMBER_CTOR | 232 | Medium |
| org.apache.maven.plugin.eclipse.EclipseToMavenMojo.writeArtifact(EclipseOsgiPlugin, Model, ArtifactRepository) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 507 | Medium |
| Method org.apache.maven.plugin.eclipse.EclipseToMavenMojo.execute() makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 236 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unwritten field: org.apache.maven.plugin.eclipse.HelpMojo.goal | CORRECTNESS | UWF_UNWRITTEN_FIELD | 74 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Read of unwritten field maven2OsgiConverter in org.apache.maven.plugin.eclipse.InstallPluginsMojo.formatEclipsePluginName(Artifact) | CORRECTNESS | NP_UNWRITTEN_FIELD | 425 | Medium |
| org.apache.maven.plugin.eclipse.InstallPluginsMojo.execute() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 192 | Medium |
| org.apache.maven.plugin.eclipse.InstallPluginsMojo.performFileOperations(boolean, Artifact, File, File) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 394 | Medium |
| Unwritten field: org.apache.maven.plugin.eclipse.InstallPluginsMojo.maven2OsgiConverter | CORRECTNESS | UWF_UNWRITTEN_FIELD | 425 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference of locationNode in new org.apache.maven.plugin.eclipse.LinkedResource(Xpp3Dom) | CORRECTNESS | NP_NULL_ON_SOME_PATH | 131 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.maven.plugin.eclipse.MakeArtifactsMojo.createGroupId(String) concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 97 | Medium |
| Unwritten field: org.apache.maven.plugin.eclipse.MakeArtifactsMojo.forcedQualifier | CORRECTNESS | UWF_UNWRITTEN_FIELD | 78 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.RadCleanMojo.handleWarLibs() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 131 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.RadPlugin.addManifestResource(EclipseWriterConfig) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 180 | Medium |
| Unwritten field: org.apache.maven.plugin.eclipse.RadPlugin.generatedResourceDirName | CORRECTNESS | UWF_UNWRITTEN_FIELD | 169 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Read of unwritten field localRepository in org.apache.maven.plugin.eclipse.RemoveCacheMojo.getNotAvailableMarkerFiles() | CORRECTNESS | NP_UNWRITTEN_FIELD | 95 | Medium |
| Unwritten field: org.apache.maven.plugin.eclipse.RemoveCacheMojo.localRepository | CORRECTNESS | UWF_UNWRITTEN_FIELD | 95 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.WorkspaceConfiguration.getWorkspaceArtefacts() may expose internal representation by returning WorkspaceConfiguration.workspaceArtefacts | MALICIOUS_CODE | EI_EXPOSE_REP | 98 | Medium |
| org.apache.maven.plugin.eclipse.WorkspaceConfiguration.setWorkspaceArtefacts(IdeDependency[]) may expose internal representation by storing an externally mutable object into WorkspaceConfiguration.workspaceArtefacts | MALICIOUS_CODE | EI_EXPOSE_REP2 | 103 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.maven.plugin.eclipse.reader.ReadWorkspaceLocations.readAvailableJREs(File, Log) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 433 | Medium |
| Method org.apache.maven.plugin.eclipse.reader.ReadWorkspaceLocations.readDefinedServers(WorkspaceConfiguration, Log) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 378 | Medium |
| org.apache.maven.plugin.eclipse.reader.ReadWorkspaceLocations.getProjectLocation(File, File) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 260 | Medium |
| org.apache.maven.plugin.eclipse.reader.ReadWorkspaceLocations.readAvailableJREs(File, Log) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 433 | Medium |
| org.apache.maven.plugin.eclipse.reader.ReadWorkspaceLocations.readDefinedServers(WorkspaceConfiguration, Log) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 378 | Medium |
| Method org.apache.maven.plugin.eclipse.reader.ReadWorkspaceLocations.detectWTPDefaultServer(WorkspaceConfiguration, String, Log) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 120 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.maven.plugin.eclipse.writers.AbstractEclipseManifestWriter.write() may fail to clean up java.io.OutputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 297 | Medium |
| org.apache.maven.plugin.eclipse.writers.AbstractEclipseManifestWriter.write() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 293 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.maven.plugin.eclipse.writers.EclipseAjdtWriter.write() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 119 | Medium |
| Method org.apache.maven.plugin.eclipse.writers.EclipseAjdtWriter.write() may fail to clean up java.io.OutputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 126 | Medium |
| org.apache.maven.plugin.eclipse.writers.EclipseAjdtWriter.write() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 119 | Medium |
| org.apache.maven.plugin.eclipse.writers.EclipseAjdtWriter.write() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 126 | Medium |
| org.apache.maven.plugin.eclipse.writers.EclipseAjdtWriter.write() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 104 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.maven.plugin.eclipse.writers.EclipseLaunchConfigurationWriter.write() concatenates strings using + in a loop | PERFORMANCE | SBSC_USE_STRINGBUFFER_CONCATENATION | 131 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.writers.EclipseManifestWriter.addManifestResource(Log, EclipseWriterConfig) ignores exceptional return value of java.io.File.createNewFile() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 154 | Medium |
| org.apache.maven.plugin.eclipse.writers.EclipseManifestWriter.addManifestResource(Log, EclipseWriterConfig) ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 152 | Medium |
| org.apache.maven.plugin.eclipse.writers.EclipseManifestWriter.addManifestResource(Log, EclipseWriterConfig) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 148 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.writers.EclipseWriterConfig.getDeps() may expose internal representation by returning EclipseWriterConfig.deps | MALICIOUS_CODE | EI_EXPOSE_REP | 174 | Medium |
| org.apache.maven.plugin.eclipse.writers.EclipseWriterConfig.getSourceDirs() may expose internal representation by returning EclipseWriterConfig.sourceDirs | MALICIOUS_CODE | EI_EXPOSE_REP | 254 | Medium |
| org.apache.maven.plugin.eclipse.writers.EclipseWriterConfig.setDeps(IdeDependency[]) may expose internal representation by storing an externally mutable object into EclipseWriterConfig.deps | MALICIOUS_CODE | EI_EXPOSE_REP2 | 184 | Medium |
| org.apache.maven.plugin.eclipse.writers.EclipseWriterConfig.setSourceDirs(EclipseSourceDir[]) may expose internal representation by storing an externally mutable object into EclipseWriterConfig.sourceDirs | MALICIOUS_CODE | EI_EXPOSE_REP2 | 264 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.apache.maven.plugin.eclipse.writers.myeclipse.MyEclipseStrutsDataWriter.strutsPatterns from instance method new org.apache.maven.plugin.eclipse.writers.myeclipse.MyEclipseStrutsDataWriter(Map) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 56 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.writers.rad.RadApplicationXMLWriter.writePrettyXmlFile(File, Xpp3Dom) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 531 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.writers.rad.RadEjbClasspathWriter.write() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 97 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.writers.rad.RadLibCopier.handleWarLibs(IdeDependency[]) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 158 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.maven.plugin.eclipse.writers.workspace.EclipseSettingsWriter.write() may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 152 | Medium |
| Method org.apache.maven.plugin.eclipse.writers.workspace.EclipseSettingsWriter.write() may fail to clean up java.io.OutputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 159 | Medium |
| org.apache.maven.plugin.eclipse.writers.workspace.EclipseSettingsWriter.write() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 152 | Medium |
| org.apache.maven.plugin.eclipse.writers.workspace.EclipseSettingsWriter.write() may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 159 | Medium |
| org.apache.maven.plugin.eclipse.writers.workspace.EclipseSettingsWriter.write() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 137 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Method org.apache.maven.plugin.eclipse.writers.workspace.EclipseWorkspaceWriter.loadProperties(File) may fail to clean up java.io.InputStream | EXPERIMENTAL | OBL_UNSATISFIED_OBLIGATION | 123 | Medium |
| org.apache.maven.plugin.eclipse.writers.workspace.EclipseWorkspaceWriter.loadProperties(File) may fail to close stream | BAD_PRACTICE | OS_OPEN_STREAM | 123 | Medium |
| org.apache.maven.plugin.eclipse.writers.workspace.EclipseWorkspaceWriter.init(Log, WorkspaceConfiguration) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 64 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.writers.wtp.EclipseWtpApplicationXMLWriter.write() ignores exceptional return value of java.io.File.delete() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 125 | Medium |
| org.apache.maven.plugin.eclipse.writers.wtp.EclipseWtpApplicationXMLWriter.write() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 120 | Medium |
| org.apache.maven.plugin.eclipse.writers.wtp.EclipseWtpApplicationXMLWriter.writePrettyXmlFile(File, Xpp3Dom) ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 614 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.writers.wtp.EclipseWtpComponentWriter.write() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 89 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.eclipse.writers.wtp.EclipseWtpFacetsWriter.write() ignores exceptional return value of java.io.File.mkdirs() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 92 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.ide.AbstractIdeSupportMojo.resolveDependenciesWithClassifier(IdeDependency[], String, boolean) ignores exceptional return value of java.io.File.createNewFile() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 1009 | Medium |
| Unwritten field: org.apache.maven.plugin.ide.AbstractIdeSupportMojo.runtimeInformation | CORRECTNESS | UWF_UNWRITTEN_FIELD | 1109 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.apache.maven.plugin.ide.IdeDependency.equals(Object) is unusual | STYLE | EQ_UNUSUAL | 589 | Medium |
| org.apache.maven.plugin.ide.IdeDependency.equals(Object) does not check for null argument | BAD_PRACTICE | NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT | 589 | High |