PMD Results

The following document contains the results of PMD 7.17.0.

Violations By Priority

Priority 3

org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java

Rule Violation Line
EmptyControlStatement Empty if statement 107–112

org/apache/maven/artifact/installer/DefaultArtifactInstaller.java

Rule Violation Line
EmptyControlStatement Empty if statement 85–90

org/apache/maven/artifact/repository/metadata/DefaultRepositoryMetadataManager.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 122–130
CollapsibleIfStatements This if statement could be combined with its parent 365–373

org/apache/maven/artifact/resolver/DefaultArtifactResolver.java

Rule Violation Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 544

org/apache/maven/artifact/resolver/WarningResolutionListener.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 31

org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 179–181
CollapsibleIfStatements This if statement could be combined with its parent 495–509
CollapsibleIfStatements This if statement could be combined with its parent 513–516
CollapsibleIfStatements This if statement could be combined with its parent 520–524
EmptyControlStatement Empty if statement 596–602

org/apache/maven/project/path/DefaultPathTranslator.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 139–141

org/apache/maven/repository/DefaultMirrorSelector.java

Rule Violation Line
AvoidUsingHardCodedIP Do not hard code the IP address ${variableName} 137

org/apache/maven/repository/MetadataResolutionResult.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'dirtyTree'. 64
UnusedPrivateField Avoid unused private fields such as 'resolvedGraph'. 68

org/apache/maven/repository/legacy/DefaultWagonManager.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'protocol'. 656

org/apache/maven/repository/legacy/resolver/DefaultLegacyArtifactCollector.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 173–180

org/apache/maven/repository/metadata/DefaultGraphConflictResolver.java

Rule Violation Line
EmptyControlStatement Empty else statement 94–100
UnusedFormalParameter Avoid unused method parameters such as 'v'. 187

org/apache/maven/repository/metadata/MetadataGraph.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'nVertices'. 218

org/apache/maven/repository/metadata/MetadataGraphEdge.java

Rule Violation Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 79

Priority 4

org/apache/maven/project/ModelUtils.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ModelUtils': 'orderAfterMerge' is already in scope 113

org/apache/maven/project/interpolation/AbstractStringBasedModelInterpolator.java

Rule Violation Line
UselessParentheses Useless parentheses around `(Throwable) next`. 280
UselessParentheses Useless parentheses around `(Throwable) next`. 282

org/apache/maven/repository/legacy/LegacyRepositorySystem.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'defaultUserLocalRepository' is already in scope because it is inherited by an enclosing type 235
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_LOCAL_REPO_ID' is already in scope because it is inherited by an enclosing type 241
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_REMOTE_REPO_URL' is already in scope because it is inherited by an enclosing type 251
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_REMOTE_REPO_ID' is already in scope because it is inherited by an enclosing type 252

org/apache/maven/repository/legacy/resolver/transform/SnapshotTransformation.java

Rule Violation Line
UselessParentheses Useless parentheses around `repoMetadata.getVersioning() != null && repoMet...`. 137–138

org/apache/maven/repository/metadata/MetadataGraphEdge.java

Rule Violation Line
UselessParentheses Useless parentheses around `source.md == null ? "no source MD" : source.md....`. 160
UselessParentheses Useless parentheses around `target.md == null ? "no target MD" : target.md....`. 161

Files

org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java

Rule Violation Priority Line
EmptyControlStatement Empty if statement 3 107–112

org/apache/maven/artifact/installer/DefaultArtifactInstaller.java

Rule Violation Priority Line
EmptyControlStatement Empty if statement 3 85–90

org/apache/maven/artifact/repository/metadata/DefaultRepositoryMetadataManager.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 122–130
CollapsibleIfStatements This if statement could be combined with its parent 3 365–373

org/apache/maven/artifact/resolver/DefaultArtifactResolver.java

Rule Violation Priority Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 3 544

org/apache/maven/artifact/resolver/WarningResolutionListener.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 3 31

org/apache/maven/project/ModelUtils.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ModelUtils': 'orderAfterMerge' is already in scope 4 113

org/apache/maven/project/inheritance/DefaultModelInheritanceAssembler.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 179–181
CollapsibleIfStatements This if statement could be combined with its parent 3 495–509
CollapsibleIfStatements This if statement could be combined with its parent 3 513–516
CollapsibleIfStatements This if statement could be combined with its parent 3 520–524
EmptyControlStatement Empty if statement 3 596–602

org/apache/maven/project/interpolation/AbstractStringBasedModelInterpolator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `(Throwable) next`. 4 280
UselessParentheses Useless parentheses around `(Throwable) next`. 4 282

org/apache/maven/project/path/DefaultPathTranslator.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 139–141

org/apache/maven/repository/DefaultMirrorSelector.java

Rule Violation Priority Line
AvoidUsingHardCodedIP Do not hard code the IP address ${variableName} 3 137

org/apache/maven/repository/MetadataResolutionResult.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'dirtyTree'. 3 64
UnusedPrivateField Avoid unused private fields such as 'resolvedGraph'. 3 68

org/apache/maven/repository/legacy/DefaultWagonManager.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'protocol'. 3 656

org/apache/maven/repository/legacy/LegacyRepositorySystem.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'defaultUserLocalRepository' is already in scope because it is inherited by an enclosing type 4 235
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_LOCAL_REPO_ID' is already in scope because it is inherited by an enclosing type 4 241
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_REMOTE_REPO_URL' is already in scope because it is inherited by an enclosing type 4 251
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_REMOTE_REPO_ID' is already in scope because it is inherited by an enclosing type 4 252

org/apache/maven/repository/legacy/resolver/DefaultLegacyArtifactCollector.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 173–180

org/apache/maven/repository/legacy/resolver/transform/SnapshotTransformation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `repoMetadata.getVersioning() != null && repoMet...`. 4 137–138

org/apache/maven/repository/metadata/DefaultGraphConflictResolver.java

Rule Violation Priority Line
EmptyControlStatement Empty else statement 3 94–100
UnusedFormalParameter Avoid unused method parameters such as 'v'. 3 187

org/apache/maven/repository/metadata/MetadataGraph.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'nVertices'. 3 218

org/apache/maven/repository/metadata/MetadataGraphEdge.java

Rule Violation Priority Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 79
UselessParentheses Useless parentheses around `source.md == null ? "no source MD" : source.md....`. 4 160
UselessParentheses Useless parentheses around `target.md == null ? "no target MD" : target.md....`. 4 161