Built by Maven

PMD Results

The following document contains the results of PMD 7.24.0.

Violations By Priority

Priority 3

org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java

Rule Violation Line
EmptyControlStatement Empty if statement 111–116

org/apache/maven/artifact/installer/DefaultArtifactInstaller.java

Rule Violation Line
EmptyControlStatement Empty if statement 90–95

org/apache/maven/artifact/repository/metadata/DefaultRepositoryMetadataManager.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 126–134
CollapsibleIfStatements This if statement could be combined with its parent 366–374

org/apache/maven/artifact/resolver/DefaultArtifactResolver.java

Rule Violation Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 549

org/apache/maven/project/path/DefaultPathTranslator.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 144–146

org/apache/maven/repository/DefaultMirrorSelector.java

Rule Violation Line
AvoidUsingHardCodedIP Do not hard code the IP address ${variableName} 141

org/apache/maven/repository/legacy/DefaultWagonManager.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'protocol'. 673

org/apache/maven/repository/legacy/resolver/DefaultLegacyArtifactCollector.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 178–185

org/apache/maven/repository/metadata/DefaultGraphConflictResolver.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'v'. 179

org/apache/maven/repository/metadata/MetadataGraph.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'nVertices'. 216

org/apache/maven/repository/metadata/MetadataGraphEdge.java

Rule Violation Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 79

org/apache/maven/toolchain/java/DefaultJavaToolChain.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 41
UselessOverridingMethod Overriding method merely calls super 46

Priority 4

org/apache/maven/artifact/metadata/AbstractArtifactMetadata.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.apache.maven.artifact.metadata': 'ArtifactMetadata' is already in scope because it is declared in the same package 29

org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositoryMetadata': 'RELEASE_OR_SNAPSHOT' is already in scope because it is inherited by an enclosing type 189
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositoryMetadata': 'RELEASE_OR_SNAPSHOT' is already in scope because it is inherited by an enclosing type 189
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositoryMetadata': 'SNAPSHOT' is already in scope because it is inherited by an enclosing type 193

org/apache/maven/repository/DefaultMirrorSelector.java

Rule Violation Line
UselessParentheses Useless parentheses around `mirrorLayout == null || mirrorLayout.isEmpty()`. 180

org/apache/maven/repository/legacy/LegacyRepositorySystem.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'defaultUserLocalRepository' is already in scope because it is inherited by an enclosing type 244
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_LOCAL_REPO_ID' is already in scope because it is inherited by an enclosing type 251
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_REMOTE_REPO_URL' is already in scope because it is inherited by an enclosing type 262
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_REMOTE_REPO_ID' is already in scope because it is inherited by an enclosing type 263

org/apache/maven/repository/legacy/resolver/transform/SnapshotTransformation.java

Rule Violation Line
UselessParentheses Useless parentheses around `repoMetadata.getVersioning() != null && repoMet...`. 142–143

org/apache/maven/repository/metadata/MetadataGraphEdge.java

Rule Violation Line
UselessParentheses Useless parentheses around `source.md == null ? "no source MD" : source.md....`. 158
UselessParentheses Useless parentheses around `target.md == null ? "no target MD" : target.md....`. 159

org/apache/maven/settings/DefaultMavenSettingsBuilder.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MavenSettingsBuilder': 'ALT_USER_SETTINGS_XML_LOCATION' is already in scope because it is inherited by an enclosing type 54
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MavenSettingsBuilder': 'ALT_GLOBAL_SETTINGS_XML_LOCATION' is already in scope because it is inherited by an enclosing type 67

org/apache/maven/toolchain/ToolchainManagerFactory.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.apache.maven.api.services': 'ToolchainManagerException' is already in scope because it is imported in this file 217

Files

org/apache/maven/artifact/deployer/DefaultArtifactDeployer.java

Rule Violation Priority Line
EmptyControlStatement Empty if statement 3 111–116

org/apache/maven/artifact/installer/DefaultArtifactInstaller.java

Rule Violation Priority Line
EmptyControlStatement Empty if statement 3 90–95

org/apache/maven/artifact/metadata/AbstractArtifactMetadata.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.apache.maven.artifact.metadata': 'ArtifactMetadata' is already in scope because it is declared in the same package 4 29

org/apache/maven/artifact/repository/metadata/AbstractRepositoryMetadata.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositoryMetadata': 'RELEASE_OR_SNAPSHOT' is already in scope because it is inherited by an enclosing type 4 189
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositoryMetadata': 'RELEASE_OR_SNAPSHOT' is already in scope because it is inherited by an enclosing type 4 189
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositoryMetadata': 'SNAPSHOT' is already in scope because it is inherited by an enclosing type 4 193

org/apache/maven/artifact/repository/metadata/DefaultRepositoryMetadataManager.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 126–134
CollapsibleIfStatements This if statement could be combined with its parent 3 366–374

org/apache/maven/artifact/resolver/DefaultArtifactResolver.java

Rule Violation Priority Line
AvoidThreadGroup Avoid using java.lang.ThreadGroup; it is not thread safe 3 549

org/apache/maven/project/path/DefaultPathTranslator.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 144–146

org/apache/maven/repository/DefaultMirrorSelector.java

Rule Violation Priority Line
AvoidUsingHardCodedIP Do not hard code the IP address ${variableName} 3 141
UselessParentheses Useless parentheses around `mirrorLayout == null || mirrorLayout.isEmpty()`. 4 180

org/apache/maven/repository/legacy/DefaultWagonManager.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'protocol'. 3 673

org/apache/maven/repository/legacy/LegacyRepositorySystem.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'defaultUserLocalRepository' is already in scope because it is inherited by an enclosing type 4 244
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_LOCAL_REPO_ID' is already in scope because it is inherited by an enclosing type 4 251
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_REMOTE_REPO_URL' is already in scope because it is inherited by an enclosing type 4 262
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RepositorySystem': 'DEFAULT_REMOTE_REPO_ID' is already in scope because it is inherited by an enclosing type 4 263

org/apache/maven/repository/legacy/resolver/DefaultLegacyArtifactCollector.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 178–185

org/apache/maven/repository/legacy/resolver/transform/SnapshotTransformation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `repoMetadata.getVersioning() != null && repoMet...`. 4 142–143

org/apache/maven/repository/metadata/DefaultGraphConflictResolver.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'v'. 3 179

org/apache/maven/repository/metadata/MetadataGraph.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'nVertices'. 3 216

org/apache/maven/repository/metadata/MetadataGraphEdge.java

Rule Violation Priority Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 79
UselessParentheses Useless parentheses around `source.md == null ? "no source MD" : source.md....`. 4 158
UselessParentheses Useless parentheses around `target.md == null ? "no target MD" : target.md....`. 4 159

org/apache/maven/settings/DefaultMavenSettingsBuilder.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MavenSettingsBuilder': 'ALT_USER_SETTINGS_XML_LOCATION' is already in scope because it is inherited by an enclosing type 4 54
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MavenSettingsBuilder': 'ALT_GLOBAL_SETTINGS_XML_LOCATION' is already in scope because it is inherited by an enclosing type 4 67

org/apache/maven/toolchain/ToolchainManagerFactory.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.apache.maven.api.services': 'ToolchainManagerException' is already in scope because it is imported in this file 4 217

org/apache/maven/toolchain/java/DefaultJavaToolChain.java

Rule Violation Priority Line
UselessOverridingMethod Overriding method merely calls super 3 41
UselessOverridingMethod Overriding method merely calls super 3 46